Skip to content

Commit

Permalink
block: Make 'bytes' param of blk_{pread,pwrite}() an int64_t
Browse files Browse the repository at this point in the history
For consistency with other I/O functions, and in preparation to
implement them using generated_co_wrapper.

Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220705161527.1054072-5-afaria@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
  • Loading branch information
albertofaria authored and XanClic committed Jul 12, 2022
1 parent a9262f5 commit 40fb486
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions block/block-backend.c
Expand Up @@ -1563,7 +1563,7 @@ BlockAIOCB *blk_aio_pwrite_zeroes(BlockBackend *blk, int64_t offset,
flags | BDRV_REQ_ZERO_WRITE, cb, opaque);
}

int blk_pread(BlockBackend *blk, int64_t offset, int bytes, void *buf,
int blk_pread(BlockBackend *blk, int64_t offset, int64_t bytes, void *buf,
BdrvRequestFlags flags)
{
int ret;
Expand All @@ -1577,8 +1577,8 @@ int blk_pread(BlockBackend *blk, int64_t offset, int bytes, void *buf,
return ret;
}

int blk_pwrite(BlockBackend *blk, int64_t offset, int bytes, const void *buf,
BdrvRequestFlags flags)
int blk_pwrite(BlockBackend *blk, int64_t offset, int64_t bytes,
const void *buf, BdrvRequestFlags flags)
{
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, buf, bytes);
IO_OR_GS_CODE();
Expand Down
6 changes: 3 additions & 3 deletions include/sysemu/block-backend-io.h
Expand Up @@ -101,10 +101,10 @@ int coroutine_fn blk_co_copy_range(BlockBackend *blk_in, int64_t off_in,
* the "I/O or GS" API.
*/

int blk_pread(BlockBackend *blk, int64_t offset, int bytes, void *buf,
int blk_pread(BlockBackend *blk, int64_t offset, int64_t bytes, void *buf,
BdrvRequestFlags flags);
int blk_pwrite(BlockBackend *blk, int64_t offset, int bytes, const void *buf,
BdrvRequestFlags flags);
int blk_pwrite(BlockBackend *blk, int64_t offset, int64_t bytes,
const void *buf, BdrvRequestFlags flags);
int coroutine_fn blk_co_preadv(BlockBackend *blk, int64_t offset,
int64_t bytes, QEMUIOVector *qiov,
BdrvRequestFlags flags);
Expand Down

0 comments on commit 40fb486

Please sign in to comment.