Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
accel: Inline WHPX get_whpx_vcpu()
No need for this helper to access the CPUState::accel field.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230624174121.11508-15-philmd@linaro.org>
  • Loading branch information
philmd committed Jun 28, 2023
1 parent b4f879a commit 441f244
Showing 1 changed file with 10 additions and 19 deletions.
29 changes: 10 additions & 19 deletions target/i386/whpx/whpx-all.c
Expand Up @@ -256,15 +256,6 @@ static bool whpx_has_xsave(void)
return whpx_xsave_cap.XsaveSupport;
}

/*
* VP support
*/

static AccelCPUState *get_whpx_vcpu(CPUState *cpu)
{
return (AccelCPUState *)cpu->accel;
}

static WHV_X64_SEGMENT_REGISTER whpx_seg_q2h(const SegmentCache *qs, int v86,
int r86)
{
Expand Down Expand Up @@ -390,7 +381,7 @@ static uint64_t whpx_cr8_to_apic_tpr(uint64_t cr8)
static void whpx_set_registers(CPUState *cpu, int level)
{
struct whpx_state *whpx = &whpx_global;
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
CPUX86State *env = cpu->env_ptr;
X86CPU *x86_cpu = X86_CPU(cpu);
struct whpx_register_set vcxt;
Expand Down Expand Up @@ -609,7 +600,7 @@ static void whpx_get_xcrs(CPUState *cpu)
static void whpx_get_registers(CPUState *cpu)
{
struct whpx_state *whpx = &whpx_global;
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
CPUX86State *env = cpu->env_ptr;
X86CPU *x86_cpu = X86_CPU(cpu);
struct whpx_register_set vcxt;
Expand Down Expand Up @@ -892,7 +883,7 @@ static const WHV_EMULATOR_CALLBACKS whpx_emu_callbacks = {
static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY_ACCESS_CONTEXT *ctx)
{
HRESULT hr;
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
WHV_EMULATOR_STATUS emu_status;

hr = whp_dispatch.WHvEmulatorTryMmioEmulation(
Expand All @@ -917,7 +908,7 @@ static int whpx_handle_portio(CPUState *cpu,
WHV_X64_IO_PORT_ACCESS_CONTEXT *ctx)
{
HRESULT hr;
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
WHV_EMULATOR_STATUS emu_status;

hr = whp_dispatch.WHvEmulatorTryIoEmulation(
Expand Down Expand Up @@ -1417,7 +1408,7 @@ static vaddr whpx_vcpu_get_pc(CPUState *cpu, bool exit_context_valid)
* of QEMU, nor this port by calling WHvSetVirtualProcessorRegisters().
* This is the most common case.
*/
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
return vcpu->exit_ctx.VpContext.Rip;
} else {
/*
Expand Down Expand Up @@ -1468,7 +1459,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu)
{
HRESULT hr;
struct whpx_state *whpx = &whpx_global;
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
CPUX86State *env = cpu->env_ptr;
X86CPU *x86_cpu = X86_CPU(cpu);
int irq;
Expand Down Expand Up @@ -1590,7 +1581,7 @@ static void whpx_vcpu_pre_run(CPUState *cpu)

static void whpx_vcpu_post_run(CPUState *cpu)
{
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
CPUX86State *env = cpu->env_ptr;
X86CPU *x86_cpu = X86_CPU(cpu);

Expand All @@ -1617,7 +1608,7 @@ static void whpx_vcpu_process_async_events(CPUState *cpu)
{
CPUX86State *env = cpu->env_ptr;
X86CPU *x86_cpu = X86_CPU(cpu);
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;

if ((cpu->interrupt_request & CPU_INTERRUPT_INIT) &&
!(env->hflags & HF_SMM_MASK)) {
Expand Down Expand Up @@ -1656,7 +1647,7 @@ static int whpx_vcpu_run(CPUState *cpu)
{
HRESULT hr;
struct whpx_state *whpx = &whpx_global;
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;
struct whpx_breakpoint *stepped_over_bp = NULL;
WhpxStepMode exclusive_step_mode = WHPX_STEP_NONE;
int ret;
Expand Down Expand Up @@ -2290,7 +2281,7 @@ int whpx_vcpu_exec(CPUState *cpu)
void whpx_destroy_vcpu(CPUState *cpu)
{
struct whpx_state *whpx = &whpx_global;
AccelCPUState *vcpu = get_whpx_vcpu(cpu);
AccelCPUState *vcpu = cpu->accel;

whp_dispatch.WHvDeleteVirtualProcessor(whpx->partition, cpu->cpu_index);
whp_dispatch.WHvEmulatorDestroyEmulator(vcpu->emulator);
Expand Down

0 comments on commit 441f244

Please sign in to comment.