Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
target/riscv: Pass RISCVCPUConfig as target_info to disassemble_info
Pass RISCVCPUConfig as disassemble_info.target_info to support disas
of conflict instructions related to specific extensions.

Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20230523093539.203909-4-liweiwei@iscas.ac.cn>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
  • Loading branch information
Weiwei Li authored and alistair23 committed Jun 13, 2023
1 parent b902ff2 commit 454c220
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
10 changes: 7 additions & 3 deletions disas/riscv.c
Expand Up @@ -19,7 +19,7 @@

#include "qemu/osdep.h"
#include "disas/dis-asm.h"

#include "target/riscv/cpu_cfg.h"

/* types */

Expand Down Expand Up @@ -969,6 +969,7 @@ typedef enum {
/* structures */

typedef struct {
RISCVCPUConfig *cfg;
uint64_t pc;
uint64_t inst;
int32_t imm;
Expand Down Expand Up @@ -4861,11 +4862,13 @@ static void decode_inst_decompress(rv_decode *dec, rv_isa isa)
/* disassemble instruction */

static void
disasm_inst(char *buf, size_t buflen, rv_isa isa, uint64_t pc, rv_inst inst)
disasm_inst(char *buf, size_t buflen, rv_isa isa, uint64_t pc, rv_inst inst,
RISCVCPUConfig *cfg)
{
rv_decode dec = { 0 };
dec.pc = pc;
dec.inst = inst;
dec.cfg = cfg;
decode_inst_opcode(&dec, isa);
decode_inst_operands(&dec, isa);
decode_inst_decompress(&dec, isa);
Expand Down Expand Up @@ -4920,7 +4923,8 @@ print_insn_riscv(bfd_vma memaddr, struct disassemble_info *info, rv_isa isa)
break;
}

disasm_inst(buf, sizeof(buf), isa, memaddr, inst);
disasm_inst(buf, sizeof(buf), isa, memaddr, inst,
(RISCVCPUConfig *)info->target_info);
(*info->fprintf_func)(info->stream, "%s", buf);

return len;
Expand Down
1 change: 1 addition & 0 deletions target/riscv/cpu.c
Expand Up @@ -849,6 +849,7 @@ static void riscv_cpu_reset_hold(Object *obj)
static void riscv_cpu_disas_set_info(CPUState *s, disassemble_info *info)
{
RISCVCPU *cpu = RISCV_CPU(s);
info->target_info = &cpu->cfg;

switch (riscv_cpu_mxl(&cpu->env)) {
case MXL_RV32:
Expand Down

0 comments on commit 454c220

Please sign in to comment.