Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
test-aio-multithread: do not use mb_read/mb_set for simple flags
The remaining use of mb_read/mb_set is just to force a thread to exit
eventually.  It does not order two memory accesses and therefore can be
just read/set.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed May 8, 2023
1 parent 6e288b0 commit 4f7335e
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tests/unit/test-aio-multithread.c
Expand Up @@ -202,7 +202,7 @@ static CoMutex comutex;

static void coroutine_fn test_multi_co_mutex_entry(void *opaque)
{
while (!qatomic_mb_read(&now_stopping)) {
while (!qatomic_read(&now_stopping)) {
qemu_co_mutex_lock(&comutex);
counter++;
qemu_co_mutex_unlock(&comutex);
Expand Down Expand Up @@ -236,7 +236,7 @@ static void test_multi_co_mutex(int threads, int seconds)

g_usleep(seconds * 1000000);

qatomic_mb_set(&now_stopping, true);
qatomic_set(&now_stopping, true);
while (running > 0) {
g_usleep(100000);
}
Expand Down Expand Up @@ -327,7 +327,7 @@ static void mcs_mutex_unlock(void)

static void test_multi_fair_mutex_entry(void *opaque)
{
while (!qatomic_mb_read(&now_stopping)) {
while (!qatomic_read(&now_stopping)) {
mcs_mutex_lock();
counter++;
mcs_mutex_unlock();
Expand Down Expand Up @@ -355,7 +355,7 @@ static void test_multi_fair_mutex(int threads, int seconds)

g_usleep(seconds * 1000000);

qatomic_mb_set(&now_stopping, true);
qatomic_set(&now_stopping, true);
while (running > 0) {
g_usleep(100000);
}
Expand Down Expand Up @@ -383,7 +383,7 @@ static QemuMutex mutex;

static void test_multi_mutex_entry(void *opaque)
{
while (!qatomic_mb_read(&now_stopping)) {
while (!qatomic_read(&now_stopping)) {
qemu_mutex_lock(&mutex);
counter++;
qemu_mutex_unlock(&mutex);
Expand Down Expand Up @@ -411,7 +411,7 @@ static void test_multi_mutex(int threads, int seconds)

g_usleep(seconds * 1000000);

qatomic_mb_set(&now_stopping, true);
qatomic_set(&now_stopping, true);
while (running > 0) {
g_usleep(100000);
}
Expand Down

0 comments on commit 4f7335e

Please sign in to comment.