Skip to content

Commit

Permalink
alsaaudio: reintroduce default recording settings
Browse files Browse the repository at this point in the history
Audio recording with ALSA default settings currently doesn't
work. The debug log shows updates every 0.75s and 1.5s.

audio: Elapsed since last alsa run (running): 0.743030
audio: Elapsed since last alsa run (running): 1.486048
audio: Elapsed since last alsa run (running): 0.743008
audio: Elapsed since last alsa run (running): 1.485878
audio: Elapsed since last alsa run (running): 1.486040
audio: Elapsed since last alsa run (running): 1.485886

The time between updates should be in the 10ms range. Audio
recording with ALSA has the same timing contraints as playback.
Reintroduce the default recording settings and use the same
default settings for recording as for playback.

The term "reintroduce" is correct because commit a93f328
("alsaaudio: port to -audiodev config") removed the default
settings for recording.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230121094735.11644-11-vr_qemu@t-online.de>
  • Loading branch information
Volker Rümelin authored and elmarco committed Mar 6, 2023
1 parent 4674473 commit 5140ad8
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions audio/alsaaudio.c
Expand Up @@ -923,15 +923,13 @@ static void *alsa_audio_init(Audiodev *dev)
dev->u.alsa.out->buffer_length = 92880;
}

/*
* OptsVisitor sets unspecified optional fields to zero, but do not depend
* on it...
*/
if (!dev->u.alsa.in->has_period_length) {
dev->u.alsa.in->period_length = 0;
/* 256 frames assuming 44100Hz */
dev->u.alsa.in->period_length = 5805;
}
if (!dev->u.alsa.in->has_buffer_length) {
dev->u.alsa.in->buffer_length = 0;
/* 4096 frames assuming 44100Hz */
dev->u.alsa.in->buffer_length = 92880;
}

return dev;
Expand Down

0 comments on commit 5140ad8

Please sign in to comment.