Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
memory: avoid updating ioeventfds for some address_space
When updating ioeventfds, we need to iterate all address spaces,
but some address spaces do not register eventfd_add|del call when
memory_listener_register() and they do nothing when updating ioeventfds.
So we can skip these AS in address_space_update_ioeventfds().

The overhead of memory_region_transaction_commit() can be significantly
reduced. For example, a VM with 8 vhost net devices and each one has
64 vectors, can reduce the time spent on memory_region_transaction_commit by 20%.

Message-ID: <20230830032906.12488-1-hongmianquan@bytedance.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: hongmianquan <hongmianquan@bytedance.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
  • Loading branch information
hongmianquan authored and davidhildenbrand committed Sep 19, 2023
1 parent 41ddcd2 commit 544cff4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions include/exec/memory.h
Expand Up @@ -1095,6 +1095,7 @@ struct AddressSpace {
struct FlatView *current_map;

int ioeventfd_nb;
int ioeventfd_notifiers;
struct MemoryRegionIoeventfd *ioeventfds;
QTAILQ_HEAD(, MemoryListener) listeners;
QTAILQ_ENTRY(AddressSpace) address_spaces_link;
Expand Down
12 changes: 12 additions & 0 deletions softmmu/memory.c
Expand Up @@ -842,6 +842,10 @@ static void address_space_update_ioeventfds(AddressSpace *as)
AddrRange tmp;
unsigned i;

if (!as->ioeventfd_notifiers) {
return;
}

/*
* It is likely that the number of ioeventfds hasn't changed much, so use
* the previous size as the starting value, with some headroom to avoid
Expand Down Expand Up @@ -3075,6 +3079,10 @@ void memory_listener_register(MemoryListener *listener, AddressSpace *as)
}

listener_add_address_space(listener, as);

if (listener->eventfd_add || listener->eventfd_del) {
as->ioeventfd_notifiers++;
}
}

void memory_listener_unregister(MemoryListener *listener)
Expand All @@ -3083,6 +3091,10 @@ void memory_listener_unregister(MemoryListener *listener)
return;
}

if (listener->eventfd_add || listener->eventfd_del) {
listener->address_space->ioeventfd_notifiers--;
}

listener_del_address_space(listener, listener->address_space);
QTAILQ_REMOVE(&memory_listeners, listener, link);
QTAILQ_REMOVE(&listener->address_space->listeners, listener, link_as);
Expand Down

0 comments on commit 544cff4

Please sign in to comment.