Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
target/riscv: Remove unused paramters in pmp_hart_has_privs_default()
The addr and size parameters in pmp_hart_has_privs_default() are unused.

Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20230517091519.34439-7-liweiwei@iscas.ac.cn>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
  • Loading branch information
Weiwei Li authored and alistair23 committed Jun 13, 2023
1 parent b84ffd6 commit 97ec5ae
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions target/riscv/pmp.c
Expand Up @@ -236,8 +236,7 @@ static int pmp_is_in_range(CPURISCVState *env, int pmp_index,
/*
* Check if the address has required RWX privs when no PMP entry is matched.
*/
static bool pmp_hart_has_privs_default(CPURISCVState *env, target_ulong addr,
target_ulong size, pmp_priv_t privs,
static bool pmp_hart_has_privs_default(CPURISCVState *env, pmp_priv_t privs,
pmp_priv_t *allowed_privs,
target_ulong mode)
{
Expand Down Expand Up @@ -309,8 +308,7 @@ bool pmp_hart_has_privs(CPURISCVState *env, target_ulong addr,

/* Short cut if no rules */
if (0 == pmp_get_num_rules(env)) {
return pmp_hart_has_privs_default(env, addr, size, privs,
allowed_privs, mode);
return pmp_hart_has_privs_default(env, privs, allowed_privs, mode);
}

if (size == 0) {
Expand Down Expand Up @@ -454,8 +452,7 @@ bool pmp_hart_has_privs(CPURISCVState *env, target_ulong addr,

/* No rule matched */
if (!ret) {
ret = pmp_hart_has_privs_default(env, addr, size, privs,
allowed_privs, mode);
ret = pmp_hart_has_privs_default(env, privs, allowed_privs, mode);
}

return ret;
Expand Down

0 comments on commit 97ec5ae

Please sign in to comment.