From af0e00db0e389dfa33d597f917a21454643bd314 Mon Sep 17 00:00:00 2001 From: John Snow Date: Fri, 13 Nov 2015 14:31:42 -0500 Subject: [PATCH] atapi: add byte_count_limit helper Signed-off-by: John Snow Tested-by: Mark Cave-Ayland Message-id: 1447095959-10046-2-git-send-email-jsnow@redhat.com --- hw/ide/atapi.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index cf0b78e3a4c3..42f78fbd7bf5 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -170,6 +170,17 @@ void ide_atapi_io_error(IDEState *s, int ret) } } +static uint16_t atapi_byte_count_limit(IDEState *s) +{ + uint16_t bcl; + + bcl = s->lcyl | (s->hcyl << 8); + if (bcl == 0xffff) { + return 0xfffe; + } + return bcl; +} + /* The whole ATAPI transfer logic is handled in this function */ void ide_atapi_cmd_reply_end(IDEState *s) { @@ -212,12 +223,10 @@ void ide_atapi_cmd_reply_end(IDEState *s) } else { /* a new transfer is needed */ s->nsector = (s->nsector & ~7) | ATAPI_INT_REASON_IO; - byte_count_limit = s->lcyl | (s->hcyl << 8); + byte_count_limit = atapi_byte_count_limit(s); #ifdef DEBUG_IDE_ATAPI printf("byte_count_limit=%d\n", byte_count_limit); #endif - if (byte_count_limit == 0xffff) - byte_count_limit--; size = s->packet_transfer_size; if (size > byte_count_limit) { /* byte count limit must be even if this case */ @@ -1272,8 +1281,7 @@ void ide_atapi_cmd(IDEState *s) * See ATA8 ACS3 section 7.17.6.49 and 7.21.5 */ if (!(atapi_cmd_table[s->io_buffer[0]].flags & NONDATA)) { /* TODO: Check IDENTIFY data word 125 for default BCL (currently 0) */ - uint16_t byte_count_limit = s->lcyl | (s->hcyl << 8); - if (!(byte_count_limit || s->atapi_dma)) { + if (!(atapi_byte_count_limit(s) || s->atapi_dma)) { /* TODO: Move abort back into core.c and make static inline again */ ide_abort_command(s); return;