From bd8892c4e6d681517c687ec5ac86eed46b3bb23b Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Mon, 23 Feb 2015 11:17:51 -0500 Subject: [PATCH] ide: prepare to move restart to common code This patch adds the restart_dma callback and adjusts the ide_restart_dma function to utilize this callback to call the BMDMA-specific restart code instead of statically executing BMDMA-specific code. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Message-id: 1424708286-16483-3-git-send-email-jsnow@redhat.com Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- hw/ide/internal.h | 1 + hw/ide/pci.c | 12 +++++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/ide/internal.h b/hw/ide/internal.h index ee9a57f03965..2566503e5cb2 100644 --- a/hw/ide/internal.h +++ b/hw/ide/internal.h @@ -437,6 +437,7 @@ struct IDEDMAOps { DMAu32Func *commit_buf; DMAIntFunc *rw_buf; DMAIntFunc *set_unit; + DMAVoidFunc *restart_dma; DMAStopFunc *set_inactive; DMAVoidFunc *cmd_done; DMARestartFunc *restart_cb; diff --git a/hw/ide/pci.c b/hw/ide/pci.c index da3e392d0a23..34fc4fbef90c 100644 --- a/hw/ide/pci.c +++ b/hw/ide/pci.c @@ -184,8 +184,9 @@ static void bmdma_set_inactive(IDEDMA *dma, bool more) } } -static void bmdma_restart_dma(BMDMAState *bm) +static void bmdma_restart_dma(IDEDMA *dma) { + BMDMAState *bm = DO_UPCAST(BMDMAState, dma, dma); IDEState *s = bmdma_active_if(bm); ide_set_sector(s, bm->sector_num); @@ -195,13 +196,13 @@ static void bmdma_restart_dma(BMDMAState *bm) static void ide_restart_dma(IDEState *s, enum ide_dma_cmd dma_cmd) { - BMDMAState *bm = DO_UPCAST(BMDMAState, dma, s->bus->dma); - - bmdma_restart_dma(bm); + if (s->bus->dma->ops->restart_dma) { + s->bus->dma->ops->restart_dma(s->bus->dma); + } s->io_buffer_index = 0; s->io_buffer_size = 0; s->dma_cmd = dma_cmd; - bmdma_start_dma(&bm->dma, s, ide_dma_cb); + ide_start_dma(s, ide_dma_cb); } /* TODO This should be common IDE code */ @@ -532,6 +533,7 @@ static const struct IDEDMAOps bmdma_ops = { .prepare_buf = bmdma_prepare_buf, .rw_buf = bmdma_rw_buf, .set_unit = bmdma_set_unit, + .restart_dma = bmdma_restart_dma, .set_inactive = bmdma_set_inactive, .restart_cb = bmdma_restart_cb, .reset = bmdma_reset,