Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
configure: check for $download value properly
If configure was invoked with --disable-download and git
submodules were not checked out a warning is produced and the
configure script fails. But the $download variable (which
reflects the enable/disable download argument) is checked for in
a weird fashion:

  test -f "$download" = disabled

Drop the '-f' to check for the actual value of the variable.

Fixes: 2019cab ("meson: subprojects: replace submodules with wrap files", 2023-06-06)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
zippy2 authored and bonzini committed Jun 7, 2023
1 parent e58e55d commit c06b157
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure
Expand Up @@ -767,7 +767,7 @@ if test "$plugins" = "yes" -a "$tcg" = "disabled"; then
fi

if ! test -f "$source_path/subprojects/keycodemapdb/README" \
&& test -f "$download" = disabled
&& test "$download" = disabled
then
echo
echo "ERROR: missing subprojects"
Expand Down

0 comments on commit c06b157

Please sign in to comment.