Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
target/arm/ptw: Don't set fi->s1ptw for UnsuppAtomicUpdate fault
For an Unsupported Atomic Update fault where the stage 1 translation
table descriptor update can't be done because it's to an unsupported
memory type, this is a stage 1 abort (per the Arm ARM R_VSXXT).  This
means we should not set fi->s1ptw, because this will cause the code
in the get_phys_addr_lpae() error-exit path to mark it as stage 2.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20230807141514.19075-2-peter.maydell@linaro.org
  • Loading branch information
pm215 committed Aug 22, 2023
1 parent 43a5e37 commit c986d86
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion target/arm/ptw.c
Expand Up @@ -701,7 +701,6 @@ static uint64_t arm_casq_ptw(CPUARMState *env, uint64_t old_val,

if (unlikely(!host)) {
fi->type = ARMFault_UnsuppAtomicUpdate;
fi->s1ptw = true;
return 0;
}

Expand Down

0 comments on commit c986d86

Please sign in to comment.