Skip to content

Commit

Permalink
hw/smbios: Fix thread count in type4
Browse files Browse the repository at this point in the history
>From SMBIOS 3.0 specification, thread count field means:

Thread Count is the total number of threads detected by the BIOS for
this processor socket. It is a processor-wide count, not a
thread-per-core count. [1]

So here we should use threads per socket other than threads per core.

[1] SMBIOS 3.0.0, section 7.5.8, Processor Information - Thread Count

Fixes: c97294e ("SMBIOS: Build aggregate smbios tables and entry point")
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Message-Id: <20230628135437.1145805-4-zhao1.liu@linux.intel.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 7298fd7)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
trueptolemy authored and Michael Tokarev committed Sep 10, 2023
1 parent c107dab commit ce2e387
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions hw/smbios/smbios.c
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,7 @@ static void smbios_build_type_4_table(MachineState *ms, unsigned instance)
{
char sock_str[128];
size_t tbl_len = SMBIOS_TYPE_4_LEN_V28;
unsigned threads_per_socket;

if (smbios_ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
tbl_len = SMBIOS_TYPE_4_LEN_V30;
Expand Down Expand Up @@ -747,17 +748,19 @@ static void smbios_build_type_4_table(MachineState *ms, unsigned instance)
SMBIOS_TABLE_SET_STR(4, asset_tag_number_str, type4.asset);
SMBIOS_TABLE_SET_STR(4, part_number_str, type4.part);

threads_per_socket = machine_topo_get_threads_per_socket(ms);

t->core_count = (ms->smp.cores > 255) ? 0xFF : ms->smp.cores;
t->core_enabled = t->core_count;

t->thread_count = (ms->smp.threads > 255) ? 0xFF : ms->smp.threads;
t->thread_count = (threads_per_socket > 255) ? 0xFF : threads_per_socket;

t->processor_characteristics = cpu_to_le16(0x02); /* Unknown */
t->processor_family2 = cpu_to_le16(0x01); /* Other */

if (tbl_len == SMBIOS_TYPE_4_LEN_V30) {
t->core_count2 = t->core_enabled2 = cpu_to_le16(ms->smp.cores);
t->thread_count2 = cpu_to_le16(ms->smp.threads);
t->thread_count2 = cpu_to_le16(threads_per_socket);
}

SMBIOS_BUILD_TABLE_POST;
Expand Down

0 comments on commit ce2e387

Please sign in to comment.