Skip to content

Commit

Permalink
dino: move from hw/hppa to hw/pci-host
Browse files Browse the repository at this point in the history
Move the DINO device implementation from hw/hppa to hw/pci-host so that it is
located with all the other PCI host bridges.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20220504092600.10048-23-mark.cave-ayland@ilande.co.uk>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  • Loading branch information
mcayland authored and taylorsimpson committed May 9, 2022
1 parent 2682c84 commit cf524d3
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 10 deletions.
2 changes: 2 additions & 0 deletions MAINTAINERS
Expand Up @@ -1113,7 +1113,9 @@ S: Odd Fixes
F: configs/devices/hppa-softmmu/default.mak
F: hw/hppa/
F: hw/net/*i82596*
F: hw/pci-host/dino.c
F: include/hw/net/lasi_82596.h
F: include/hw/pci-host/dino.h
F: pc-bios/hppa-firmware.img

M68K Machines
Expand Down
2 changes: 1 addition & 1 deletion hw/hppa/Kconfig
Expand Up @@ -3,7 +3,7 @@ config HPPA_B160L
imply PCI_DEVICES
imply E1000_PCI
imply VIRTIO_VGA
select PCI
select DINO
select SERIAL
select ISA_BUS
select I8259
Expand Down
2 changes: 1 addition & 1 deletion hw/hppa/machine.c
Expand Up @@ -17,7 +17,7 @@
#include "hw/char/serial.h"
#include "hw/net/lasi_82596.h"
#include "hw/nmi.h"
#include "dino.h"
#include "hw/pci-host/dino.h"
#include "hppa_sys.h"
#include "qemu/units.h"
#include "qapi/error.h"
Expand Down
2 changes: 1 addition & 1 deletion hw/hppa/meson.build
@@ -1,4 +1,4 @@
hppa_ss = ss.source_set()
hppa_ss.add(when: 'CONFIG_HPPA_B160L', if_true: files('pci.c', 'machine.c', 'dino.c', 'lasi.c'))
hppa_ss.add(when: 'CONFIG_HPPA_B160L', if_true: files('pci.c', 'machine.c', 'lasi.c'))

hw_arch += {'hppa': hppa_ss}
5 changes: 0 additions & 5 deletions hw/hppa/trace-events
Expand Up @@ -3,11 +3,6 @@
# pci.c
hppa_pci_iack_write(void) ""

# dino.c
dino_chip_mem_valid(uint64_t addr, uint32_t val) "access to addr 0x%"PRIx64" is %d"
dino_chip_read(uint64_t addr, uint32_t val) "addr 0x%"PRIx64" val 0x%08x"
dino_chip_write(uint64_t addr, uint32_t val) "addr 0x%"PRIx64" val 0x%08x"

# lasi.c
lasi_chip_mem_valid(uint64_t addr, uint32_t val) "access to addr 0x%"PRIx64" is %d"
lasi_chip_read(uint64_t addr, uint32_t val) "addr 0x%"PRIx64" val 0x%08x"
Expand Down
4 changes: 4 additions & 0 deletions hw/pci-host/Kconfig
Expand Up @@ -77,3 +77,7 @@ config MV64361
bool
select PCI
select I8259

config DINO
bool
select PCI
3 changes: 1 addition & 2 deletions hw/hppa/dino.c → hw/pci-host/dino.c
Expand Up @@ -18,9 +18,8 @@
#include "hw/pci/pci.h"
#include "hw/pci/pci_bus.h"
#include "hw/qdev-properties.h"
#include "dino.h"
#include "hw/pci-host/dino.h"
#include "migration/vmstate.h"
#include "hppa_sys.h"
#include "trace.h"
#include "qom/object.h"

Expand Down
3 changes: 3 additions & 0 deletions hw/pci-host/meson.build
Expand Up @@ -25,6 +25,9 @@ pci_ss.add(when: 'CONFIG_MV64361', if_true: files('mv64361.c'))
# ARM devices
pci_ss.add(when: 'CONFIG_VERSATILE_PCI', if_true: files('versatile.c'))

# HPPA devices
pci_ss.add(when: 'CONFIG_DINO', if_true: files('dino.c'))

softmmu_ss.add_all(when: 'CONFIG_PCI', if_true: pci_ss)

specific_ss.add(when: 'CONFIG_PCI_POWERNV', if_true: files(
Expand Down
5 changes: 5 additions & 0 deletions hw/pci-host/trace-events
Expand Up @@ -34,3 +34,8 @@ unin_read(uint64_t addr, uint64_t value) "addr=0x%" PRIx64 " val=0x%"PRIx64
pnv_phb4_xive_notify(uint64_t notif_port, uint64_t data) "notif=@0x%"PRIx64" data=0x%"PRIx64
pnv_phb4_xive_notify_ic(uint64_t addr, uint64_t data) "addr=@0x%"PRIx64" data=0x%"PRIx64
pnv_phb4_xive_notify_abt(uint64_t notif_port, uint64_t data) "notif=@0x%"PRIx64" data=0x%"PRIx64

# dino.c
dino_chip_mem_valid(uint64_t addr, uint32_t val) "access to addr 0x%"PRIx64" is %d"
dino_chip_read(uint64_t addr, uint32_t val) "addr 0x%"PRIx64" val 0x%08x"
dino_chip_write(uint64_t addr, uint32_t val) "addr 0x%"PRIx64" val 0x%08x"
File renamed without changes.

0 comments on commit cf524d3

Please sign in to comment.