Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
file-posix: Simplify raw_co_prw's 'out' zone code
We duplicate the same condition three times here, pull it out to the top
level.

Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230824155345.109765-5-hreitz@redhat.com>
Reviewed-by: Sam Li <faithilikerun@gmail.com>
  • Loading branch information
XanClic committed Aug 29, 2023
1 parent deab5c9 commit d31b50a
Showing 1 changed file with 5 additions and 13 deletions.
18 changes: 5 additions & 13 deletions block/file-posix.c
Expand Up @@ -2506,11 +2506,10 @@ static int coroutine_fn raw_co_prw(BlockDriverState *bs, uint64_t offset,

out:
#if defined(CONFIG_BLKZONED)
{
BlockZoneWps *wps = bs->wps;
if (ret == 0) {
if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
bs->bl.zoned != BLK_Z_NONE) {
if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
bs->bl.zoned != BLK_Z_NONE) {
BlockZoneWps *wps = bs->wps;
if (ret == 0) {
uint64_t *wp = &wps->wp[offset / bs->bl.zone_size];
if (!BDRV_ZT_IS_CONV(*wp)) {
if (type & QEMU_AIO_ZONE_APPEND) {
Expand All @@ -2523,19 +2522,12 @@ static int coroutine_fn raw_co_prw(BlockDriverState *bs, uint64_t offset,
*wp = offset + bytes;
}
}
}
} else {
if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
bs->bl.zoned != BLK_Z_NONE) {
} else {
update_zones_wp(bs, s->fd, 0, 1);
}
}

if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
bs->blk.zoned != BLK_Z_NONE) {
qemu_co_mutex_unlock(&wps->colock);
}
}
#endif
return ret;
}
Expand Down

0 comments on commit d31b50a

Please sign in to comment.