Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
iotests/iov-padding: New test
Test that even vectored IO requests with 1024 vector elements that are
not aligned to the device's request alignment will succeed.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230411173418.19549-5-hreitz@redhat.com>
  • Loading branch information
XanClic committed Jun 5, 2023
1 parent cc63f6f commit d7e1905
Show file tree
Hide file tree
Showing 2 changed files with 144 additions and 0 deletions.
85 changes: 85 additions & 0 deletions tests/qemu-iotests/tests/iov-padding
@@ -0,0 +1,85 @@
#!/usr/bin/env bash
# group: rw quick
#
# Check the interaction of request padding (to fit alignment restrictions) with
# vectored I/O from the guest
#
# Copyright Red Hat
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#

seq=$(basename $0)
echo "QA output created by $seq"

status=1 # failure is the default!

_cleanup()
{
_cleanup_test_img
}
trap "_cleanup; exit \$status" 0 1 2 3 15

# get standard environment, filters and checks
cd ..
. ./common.rc
. ./common.filter

_supported_fmt raw
_supported_proto file

_make_test_img 1M

IMGSPEC="driver=blkdebug,align=4096,image.driver=file,image.filename=$TEST_IMG"

# Four combinations:
# - Offset 4096, length 1023 * 512 + 512: Fully aligned to 4k
# - Offset 4096, length 1023 * 512 + 4096: Head is aligned, tail is not
# - Offset 512, length 1023 * 512 + 512: Neither head nor tail are aligned
# - Offset 512, length 1023 * 512 + 4096: Tail is aligned, head is not
for start_offset in 4096 512; do
for last_element_length in 512 4096; do
length=$((1023 * 512 + $last_element_length))

echo
echo "== performing 1024-element vectored requests to image (offset: $start_offset; length: $length) =="

# Fill with data for testing
$QEMU_IO -c 'write -P 1 0 1M' "$TEST_IMG" | _filter_qemu_io

# 1023 512-byte buffers, and then one with length $last_element_length
cmd_params="-P 2 $start_offset $(yes 512 | head -n 1023 | tr '\n' ' ') $last_element_length"
QEMU_IO_OPTIONS="$QEMU_IO_OPTIONS_NO_FMT" $QEMU_IO \
-c "writev $cmd_params" \
--image-opts \
"$IMGSPEC" \
| _filter_qemu_io

# Read all patterns -- read the part we just wrote with writev twice,
# once "normally", and once with a readv, so we see that that works, too
QEMU_IO_OPTIONS="$QEMU_IO_OPTIONS_NO_FMT" $QEMU_IO \
-c "read -P 1 0 $start_offset" \
-c "read -P 2 $start_offset $length" \
-c "readv $cmd_params" \
-c "read -P 1 $((start_offset + length)) $((1024 * 1024 - length - start_offset))" \
--image-opts \
"$IMGSPEC" \
| _filter_qemu_io
done
done

# success, all done
echo "*** done"
rm -f $seq.full
status=0
59 changes: 59 additions & 0 deletions tests/qemu-iotests/tests/iov-padding.out
@@ -0,0 +1,59 @@
QA output created by iov-padding
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576

== performing 1024-element vectored requests to image (offset: 4096; length: 524288) ==
wrote 1048576/1048576 bytes at offset 0
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
wrote 524288/524288 bytes at offset 4096
512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 4096/4096 bytes at offset 0
4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 524288/524288 bytes at offset 4096
512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 524288/524288 bytes at offset 4096
512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 520192/520192 bytes at offset 528384
508 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

== performing 1024-element vectored requests to image (offset: 4096; length: 527872) ==
wrote 1048576/1048576 bytes at offset 0
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
wrote 527872/527872 bytes at offset 4096
515.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 4096/4096 bytes at offset 0
4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 527872/527872 bytes at offset 4096
515.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 527872/527872 bytes at offset 4096
515.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 516608/516608 bytes at offset 531968
504.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

== performing 1024-element vectored requests to image (offset: 512; length: 524288) ==
wrote 1048576/1048576 bytes at offset 0
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
wrote 524288/524288 bytes at offset 512
512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 512/512 bytes at offset 0
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 524288/524288 bytes at offset 512
512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 524288/524288 bytes at offset 512
512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 523776/523776 bytes at offset 524800
511.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)

== performing 1024-element vectored requests to image (offset: 512; length: 527872) ==
wrote 1048576/1048576 bytes at offset 0
1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
wrote 527872/527872 bytes at offset 512
515.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 512/512 bytes at offset 0
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 527872/527872 bytes at offset 512
515.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 527872/527872 bytes at offset 512
515.500 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
read 520192/520192 bytes at offset 528384
508 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
*** done

0 comments on commit d7e1905

Please sign in to comment.