Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
ui/dbus: add a FIXME about texture/dmabuf scanout handling
Except SDL, display backends seem to fail at handing full scanout
geometry correctly. It would need some test/reproducer to actually check
it. In the meantime, fill some missing fields, and leave a FIXME.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20230515132537.1026310-1-marcandre.lureau@redhat.com>
  • Loading branch information
elmarco committed May 28, 2023
1 parent 57430aa commit da1d066
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions ui/dbus-listener.c
Expand Up @@ -102,6 +102,7 @@ static void dbus_scanout_dmabuf(DisplayChangeListener *dcl,
return;
}

/* FIXME: add missing x/y/w/h support */
qemu_dbus_display1_listener_call_scanout_dmabuf(
ddl->proxy,
g_variant_new_handle(0),
Expand Down Expand Up @@ -129,6 +130,10 @@ static void dbus_scanout_texture(DisplayChangeListener *dcl,
.width = backing_width,
.height = backing_height,
.y0_top = backing_y_0_top,
.x = x,
.y = y,
.scanout_width = w,
.scanout_height = h,
};

assert(tex_id);
Expand Down

0 comments on commit da1d066

Please sign in to comment.