Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
virtio-net: not enable vq reset feature unconditionally
The commit 93a97dc ("virtio-net: enable vq reset feature") enables
unconditionally vq reset feature as long as the device is emulated.
This makes impossible to actually disable the feature, and it causes
migration problems from qemu version previous than 7.2.

The entire final commit is unneeded as device system already enable or
disable the feature properly.

This reverts commit 93a97dc.
Fixes: 93a97dc ("virtio-net: enable vq reset feature")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>

Message-Id: <20230504101447.389398-1-eperezma@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 1fac00f)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
eugpermar authored and Michael Tokarev committed May 22, 2023
1 parent 6f4dc62 commit dd63d3a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hw/net/virtio-net.c
Expand Up @@ -802,7 +802,6 @@ static uint64_t virtio_net_get_features(VirtIODevice *vdev, uint64_t features,
}

if (!get_vhost_net(nc->peer)) {
virtio_add_feature(&features, VIRTIO_F_RING_RESET);
return features;
}

Expand Down

0 comments on commit dd63d3a

Please sign in to comment.