Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
scripts: Add qom-cast-macro-clean-cocci-gen.py
Add a script to generate Coccinelle semantic patch removing all pointless QOM cast macro uses. Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230601093452.38972-2-philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Thomas Huth <thuth@redhat.com>
- Loading branch information
Showing
2 changed files
with
50 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| #!/usr/bin/env python3 | ||
| # | ||
| # Generate a Coccinelle semantic patch to remove pointless QOM cast. | ||
| # | ||
| # Usage: | ||
| # | ||
| # $ qom-cast-macro-clean-cocci-gen.py $(git ls-files) > qom_pointless_cast.cocci | ||
| # $ spatch \ | ||
| # --macro-file scripts/cocci-macro-file.h \ | ||
| # --sp-file qom_pointless_cast.cocci \ | ||
| # --keep-comments \ | ||
| # --use-gitgrep \ | ||
| # --in-place \ | ||
| # --dir . | ||
| # | ||
| # SPDX-FileContributor: Philippe Mathieu-Daudé <philmd@linaro.org> | ||
| # SPDX-FileCopyrightText: 2023 Linaro Ltd. | ||
| # SPDX-License-Identifier: GPL-2.0-or-later | ||
|
|
||
| import re | ||
| import sys | ||
|
|
||
| assert len(sys.argv) > 0 | ||
|
|
||
| def print_cocci_rule(qom_typedef, qom_cast_macro): | ||
| print(f'''@@ | ||
| typedef {qom_typedef}; | ||
| {qom_typedef} *obj; | ||
| @@ | ||
| - {qom_cast_macro}(obj) | ||
| + obj | ||
| ''') | ||
|
|
||
| patterns = [ | ||
| r'DECLARE_INSTANCE_CHECKER\((\w+),\W*(\w+),\W*TYPE_\w+\)', | ||
| r'DECLARE_OBJ_CHECKERS\((\w+),\W*\w+,\W*(\w+),\W*TYPE_\w+\)', | ||
| r'OBJECT_DECLARE_TYPE\((\w+),\W*\w+,\W*(\w+)\)', | ||
| r'OBJECT_DECLARE_SIMPLE_TYPE\((\w+),\W*(\w+)\)', | ||
| r'INTERFACE_CHECK\((\w+),\W*\(\w+\),\W*TYPE_(\w+)\)', | ||
| ] | ||
|
|
||
| for fn in sys.argv[1:]: | ||
| try: | ||
| content = open(fn, 'rt').read() | ||
| except: | ||
| continue | ||
| for pattern in patterns: | ||
| for match in re.findall(pattern, content): | ||
| print_cocci_rule(match[0], match[1]) |