From e549d2aaeba1cfac207c9a9675cc203e6372a22e Mon Sep 17 00:00:00 2001 From: Bandan Das Date: Wed, 3 Jun 2015 18:38:10 -0400 Subject: [PATCH] monitor: Fix failure path for "S" argument Since the "S" argument type is only used with the "?" flag, the bug can't bite. Signed-off-by: Bandan Das Acked-by: Luiz Capitulino Signed-off-by: Markus Armbruster --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 4c7faf9716ff..8b1dbf85c1b2 100644 --- a/monitor.c +++ b/monitor.c @@ -4016,7 +4016,7 @@ static QDict *monitor_parse_arguments(Monitor *mon, if (len <= 0) { monitor_printf(mon, "%s: string expected\n", cmd->name); - break; + goto fail; } qdict_put(qdict, key, qstring_from_str(p)); p += len;