Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
target/i386: Rename helper template headers as '.h.inc'
Since commit 139c183 ("meson: rename included C source files
to .c.inc"), QEMU standard procedure for included C files is to
use *.c.inc.

Besides, since commit 6a0057a ("docs/devel: make a statement
about includes") this is documented as the Coding Style:

  If you do use template header files they should be named with
  the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
  being included for expansion.

Therefore move the included templates in the tcg/ directory and
rename as '.h.inc'.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230608133108.72655-5-philmd@linaro.org>
  • Loading branch information
philmd committed Jun 13, 2023
1 parent 6d70b36 commit f1cc7c2
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions target/i386/helper.h
Expand Up @@ -203,11 +203,11 @@ DEF_HELPER_1(enter_mmx, void, env)
DEF_HELPER_1(emms, void, env)

#define SHIFT 0
#include "ops_sse_header.h"
#include "tcg/ops_sse_header.h.inc"
#define SHIFT 1
#include "ops_sse_header.h"
#include "tcg/ops_sse_header.h.inc"
#define SHIFT 2
#include "ops_sse_header.h"
#include "tcg/ops_sse_header.h.inc"

DEF_HELPER_3(rclb, tl, env, tl, tl)
DEF_HELPER_3(rclw, tl, env, tl, tl)
Expand Down
8 changes: 4 additions & 4 deletions target/i386/tcg/cc_helper.c
Expand Up @@ -58,21 +58,21 @@ const uint8_t parity_table[256] = {
};

#define SHIFT 0
#include "cc_helper_template.h"
#include "cc_helper_template.h.inc"
#undef SHIFT

#define SHIFT 1
#include "cc_helper_template.h"
#include "cc_helper_template.h.inc"
#undef SHIFT

#define SHIFT 2
#include "cc_helper_template.h"
#include "cc_helper_template.h.inc"
#undef SHIFT

#ifdef TARGET_X86_64

#define SHIFT 3
#include "cc_helper_template.h"
#include "cc_helper_template.h.inc"
#undef SHIFT

#endif
Expand Down
File renamed without changes.
8 changes: 4 additions & 4 deletions target/i386/tcg/int_helper.c
Expand Up @@ -448,20 +448,20 @@ target_ulong helper_pext(target_ulong src, target_ulong mask)
}

#define SHIFT 0
#include "shift_helper_template.h"
#include "shift_helper_template.h.inc"
#undef SHIFT

#define SHIFT 1
#include "shift_helper_template.h"
#include "shift_helper_template.h.inc"
#undef SHIFT

#define SHIFT 2
#include "shift_helper_template.h"
#include "shift_helper_template.h.inc"
#undef SHIFT

#ifdef TARGET_X86_64
#define SHIFT 3
#include "shift_helper_template.h"
#include "shift_helper_template.h.inc"
#undef SHIFT
#endif

Expand Down
File renamed without changes.
File renamed without changes.

0 comments on commit f1cc7c2

Please sign in to comment.