Skip to content

Commit

Permalink
target/ppc: Disable goto_tb with architectural singlestep
Browse files Browse the repository at this point in the history
The change to use translator_use_goto_tb went too far, as the
CF_SINGLE_STEP flag managed by the translator only handles
gdb single stepping and not the architectural single stepping
modeled in DisasContext.singlestep_enabled.

Fixes: 6e9cc37 ("target/ppc: Use translator_use_goto_tb")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1795
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
(cherry picked from commit 2e718e6)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
rth7680 authored and Michael Tokarev committed Aug 4, 2023
1 parent 357b424 commit f8e673d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions target/ppc/translate.c
Original file line number Diff line number Diff line change
Expand Up @@ -4132,6 +4132,9 @@ static void pmu_count_insns(DisasContext *ctx)

static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest)
{
if (unlikely(ctx->singlestep_enabled)) {
return false;
}
return translator_use_goto_tb(&ctx->base, dest);
}

Expand Down

0 comments on commit f8e673d

Please sign in to comment.