Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
disas: Move disas.c into the target-independent source set
By using target_words_bigendian() instead of an ifdef,
we can build this code once.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230508133745.109463-3-thuth@redhat.com>
[rth: Type change done in a separate patch]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
  • Loading branch information
huth authored and rth7680 committed May 11, 2023
1 parent 4e8c91a commit faef3c0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
10 changes: 5 additions & 5 deletions disas/disas.c
Expand Up @@ -122,11 +122,11 @@ void disas_initialize_debug_target(CPUDebug *s, CPUState *cpu)
s->cpu = cpu;
s->info.read_memory_func = target_read_memory;
s->info.print_address_func = print_address;
#if TARGET_BIG_ENDIAN
s->info.endian = BFD_ENDIAN_BIG;
#else
s->info.endian = BFD_ENDIAN_LITTLE;
#endif
if (target_words_bigendian()) {
s->info.endian = BFD_ENDIAN_BIG;
} else {
s->info.endian = BFD_ENDIAN_LITTLE;
}

CPUClass *cc = CPU_GET_CLASS(cpu);
if (cc->disas_set_info) {
Expand Down
3 changes: 2 additions & 1 deletion disas/meson.build
Expand Up @@ -11,6 +11,7 @@ common_ss.add(when: 'CONFIG_SH4_DIS', if_true: files('sh4.c'))
common_ss.add(when: 'CONFIG_SPARC_DIS', if_true: files('sparc.c'))
common_ss.add(when: 'CONFIG_XTENSA_DIS', if_true: files('xtensa.c'))
common_ss.add(when: capstone, if_true: [files('capstone.c'), capstone])
common_ss.add(files('disas.c'))

softmmu_ss.add(files('disas-mon.c'))
specific_ss.add(files('disas.c'), capstone)
specific_ss.add(capstone)

0 comments on commit faef3c0

Please sign in to comment.