Skip to content

Commit

Permalink
qemu-file: Rename qemu_file_transferred_ fast -> noflush
Browse files Browse the repository at this point in the history
Fast don't say much.  Noflush indicates more clearly that it is like
qemu_file_transferred but without the flush.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230530183941.7223-2-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
  • Loading branch information
Juan Quintela committed Jul 26, 2023
1 parent 06c48d6 commit fc95c63
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion migration/qemu-file.c
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ int coroutine_mixed_fn qemu_get_byte(QEMUFile *f)
return result;
}

uint64_t qemu_file_transferred_fast(QEMUFile *f)
uint64_t qemu_file_transferred_noflush(QEMUFile *f)
{
uint64_t ret = f->total_transferred;
int i;
Expand Down
11 changes: 5 additions & 6 deletions migration/qemu-file.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,15 @@ int qemu_fclose(QEMUFile *f);
uint64_t qemu_file_transferred(QEMUFile *f);

/*
* qemu_file_transferred_fast:
* qemu_file_transferred_noflush:
*
* As qemu_file_transferred except for writable
* files, where no flush is performed and the reported
* amount will include the size of any queued buffers,
* on top of the amount actually transferred.
* As qemu_file_transferred except for writable files, where no flush
* is performed and the reported amount will include the size of any
* queued buffers, on top of the amount actually transferred.
*
* Returns: the total bytes transferred and queued
*/
uint64_t qemu_file_transferred_fast(QEMUFile *f);
uint64_t qemu_file_transferred_noflush(QEMUFile *f);

/*
* put_buffer without copying the buffer.
Expand Down
4 changes: 2 additions & 2 deletions migration/savevm.c
Original file line number Diff line number Diff line change
Expand Up @@ -927,9 +927,9 @@ static int vmstate_load(QEMUFile *f, SaveStateEntry *se)
static void vmstate_save_old_style(QEMUFile *f, SaveStateEntry *se,
JSONWriter *vmdesc)
{
uint64_t old_offset = qemu_file_transferred_fast(f);
uint64_t old_offset = qemu_file_transferred_noflush(f);
se->ops->save_state(f, se->opaque);
uint64_t size = qemu_file_transferred_fast(f) - old_offset;
uint64_t size = qemu_file_transferred_noflush(f) - old_offset;

if (vmdesc) {
json_writer_int64(vmdesc, "size", size);
Expand Down
4 changes: 2 additions & 2 deletions migration/vmstate.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
void *curr_elem = first_elem + size * i;

vmsd_desc_field_start(vmsd, vmdesc_loop, field, i, n_elems);
old_offset = qemu_file_transferred_fast(f);
old_offset = qemu_file_transferred_noflush(f);
if (field->flags & VMS_ARRAY_OF_POINTER) {
assert(curr_elem);
curr_elem = *(void **)curr_elem;
Expand Down Expand Up @@ -391,7 +391,7 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
return ret;
}

written_bytes = qemu_file_transferred_fast(f) - old_offset;
written_bytes = qemu_file_transferred_noflush(f) - old_offset;
vmsd_desc_field_end(vmsd, vmdesc_loop, field, written_bytes, i);

/* Compressed arrays only care about the first element */
Expand Down

0 comments on commit fc95c63

Please sign in to comment.