Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
git-submodule: allow partial update of .git-submodule-status
Allow a specific subdirectory to run git-submodule.sh with only a
subset of submodules, without removing the others from the
.git-submodule-status file.

This also allows scripts/git-submodule.sh to be more lenient:
validating an empty set of submodules is not a mistake.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Jun 6, 2023
1 parent ac4ccac commit fdb8fd8
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions scripts/git-submodule.sh
Expand Up @@ -72,12 +72,8 @@ done

case "$command" in
status|validate)
if test -z "$maybe_modules"
then
test -s ${substat} && validate_error "$command" || exit 0
fi

test -f "$substat" || validate_error "$command"
test -z "$maybe_modules" && exit 0
for module in $modules; do
CURSTATUS=$($GIT submodule status $module)
OLDSTATUS=$(cat $substat | grep $module)
Expand All @@ -88,17 +84,23 @@ status|validate)
exit 0
;;
update)
if test -z "$maybe_modules"
then
test -e $substat || touch $substat
exit 0
fi
test -e $substat || touch $substat
test -z "$maybe_modules" && exit 0

$GIT submodule update --init $modules 1>/dev/null
test $? -ne 0 && update_error "failed to update modules"

$GIT submodule status $modules > "${substat}"
test $? -ne 0 && update_error "failed to save git submodule status" >&2
(while read -r; do
for module in $modules; do
case $REPLY in
*" $module "*) continue 2 ;;
esac
done
printf '%s\n' "$REPLY"
done
$GIT submodule status $modules
test $? -ne 0 && update_error "failed to save git submodule status" >&2) < $substat > $substat.new
mv -f $substat.new $substat
;;
esac

Expand Down

0 comments on commit fdb8fd8

Please sign in to comment.