Permalink
Commits on May 26, 2016
  1. qdev: Start disentangling bus from device

    Move bus type and related APIs to a separate file bus.c.
    This is a first step in breaking up qdev.c into more manageable chunks.
    
    Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
    [AF: Rebased onto osdep.h]
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    [PMM: added bus.o to link line for test-qdev-global-props]
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    afaerber committed with pm215 Jul 13, 2015
Commits on May 25, 2016
  1. MAINTAINERS: Drop Andreas as CPU maintainer

    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed May 25, 2016
  2. MAINTAINERS: Drop Andreas as 0.15 maintainer

    Downgrade to orphan status, like all other remaining stable entries.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed May 25, 2016
  3. MAINTAINERS: Drop Andreas as PReP maintainer

    Signed-off-by: Andreas Färber <andreas.faerber@web.de>
    afaerber committed with afaerber May 25, 2016
  4. MAINTAINERS: Drop Andreas as Cocoa maintainer

    Peter has taken over Cocoa maintainership.
    
    Signed-off-by: Andreas Färber <andreas.faerber@web.de>
    afaerber committed with afaerber May 25, 2016
Commits on Apr 18, 2016
  1. MAINTAINERS: Drop target-i386 from CPU subsystem

    X86CPU QOM type is in good hands and actively maintained these days, so
    drop it from the generic QOM CPU subsystem.
    
    Some refactorings and design questions will still intersect, but review
    and discussions of individual series can still take place while opting out
    of general X86CPU patch review.
    
    Acked-by: Eduardo Habkost <ehabkost@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Feb 12, 2016
Commits on Jan 18, 2016
  1. MAINTAINERS: Fix sPAPR entry heading

    get_maintainers.pl does not handle parenthesis in maintenance areas well
    in connection with list emails (here: qemu-ppc@nongnu.org).
    
    Resolve a recurring CC issue breaking git-send-email by reverting part
    of commit 085eb21 ("Add David Gibson
    for sPAPR in MAINTAINERS file").
    
    Cc: David Gibson <david@gibson.dropbear.id.au>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Jan 18, 2016
Commits on Dec 3, 2015
  1. tests: Fix check-report-qtest-% target

    Commit e253c28 ("tests: Fix how qom-test is run") introduced
    $(qtest-generic-y) and used it for check-qtest-% target, but did not
    update check-report-qtest-%. This causes check-report-qtest-aarch64.xml
    target to fail with a gtester usage error for lack of test arguments.
    
    Fix this by adding $(qtest-generic-y) in check-report-qtest-%.
    Also add it in check-clean target, spotted by Markus.
    
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Nov 21, 2015
Commits on Nov 19, 2015
  1. MAINTAINERS: Add check-qom-{interface,proplist} to QOM

    Add the QOM unit tests to the QOM maintenance area so that maintainers
    get CC'ed on changes and to document QOM test coverage.
    
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Nov 18, 2015
  2. qom: Clean up assertions to display values on failure

    Instead of using g_assert() for integer comparisons, use
    g_assert_cmpint() so that we can see the respective values.
    
    While at it, fix one stray indentation.
    
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Nov 16, 2015
Commits on Oct 24, 2015
  1. tests: Add ivshmem qtest

    Note that it launches two instances, as sharing memory is the purpose of
    ivshmem.
    
    Cc: Cam Macdonell <cam@cs.ualberta.ca>
    Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    [ Remove Nahanni codename, add test to pci set - Marc-André ]
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    afaerber committed with elmarco Oct 10, 2015
Commits on Sep 19, 2015
  1. Revert use of DEFINE_MACHINE() for registrations of multiple machines

    The script used for converting from QEMUMachine had used one
    DEFINE_MACHINE() per machine registered. In cases where multiple
    machines are registered from one source file, avoid the excessive
    generation of module init functions by reverting this unrolling.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Sep 19, 2015
Commits on Aug 3, 2015
  1. configure: Drop vnc-ws feature from help text

    Commit 8e9b0d2 (ui: convert VNC websockets to use crypto APIs) dropped
    the --enable-vnc-ws option but forgot to update the help text. Fix this.
    
    Cc: Daniel P. Berrange <berrange@redhat.com>
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Message-id: 1437749257-3313-1-git-send-email-afaerber@suse.de
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    afaerber committed with pm215 Jul 24, 2015
Commits on Jun 19, 2015
  1. tests: Use qtest_add_data_func() consistently

    Replace uses of g_test_add_data_func() for QTest test cases.
    
    It is still valid to use it for any non-QTest test cases,
    which are not run for multiple target binaries.
    
    Suggested-by: John Snow <jsnow@redhat.com>
    Reviewed-by: John Snow <jsnow@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 25, 2015
Commits on Jun 2, 2015
  1. pc: Ensure non-zero CPU ref count after attaching to ICC bus

    Setting the parent bus of a device increases its ref count, which we
    ultimately want to level out. However it is only safe to do so after the
    last reference to the device in local code, as qom-set or similar operations
    might decrease the ref count.
    
    Therefore move the object_unref() from pc_new_cpu() into its callers.
    
    The APIC operations on the last CPU in pc_cpus_init() are still potentially
    insecure, but that is beyond the scope of this code movement.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Acked-by: Michael S. Tsirkin <mst@redhat.com>
    Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    afaerber committed with ehabkost Mar 17, 2015
Commits on Apr 13, 2015
  1. stm32f205: Fix SoC type name

    The type name for the SoC device, unlike those of its sub-devices,
    did not follow the QOM naming conventions. While the usage is internal
    only, this is exposed through QMP and HMP, so fix it before release.
    
    Cc: Alistair Francis <alistair.francis@xilinx.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Reviewed-by: Alistair Francis <alistair@alistair23.me>
    Message-id: 1428676676-23056-1-git-send-email-afaerber@suse.de
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    afaerber committed with pm215 Apr 10, 2015
Commits on Mar 31, 2015
  1. qom: Fix object_property_add_alias() with [*]

    Commit 8074264 (qom: Add description field in ObjectProperty struct)
    introduced property descriptions and copied them for alias properties.
    
    Instead of using the caller-supplied property name, use the returned
    property name for setting the description. This avoids an Error when
    setting a property description for a property with literal "[*]" that
    doesn't exist due to automatic property naming in object_property_add().
    
    Reviewed-by: Gonglei <arei.gonglei@huawei.com>
    Acked-by: Paolo Bonzini <pbonzini@redhat.com>
    Cc: Michael S. Tsirkin <mst@redhat.com>
    Cc: qemu-stable@nongnu.org (v2.2+)
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 27, 2015
Commits on Mar 30, 2015
  1. i440fx-test: Fix test paths to include architecture

    Replace g_test_add_func() with new qtest_add_func() and g_test_add()
    macro with qtest_add() macro. This effectively changes GTester paths:
    
      /i440fx/foo -> /x86_64/i440fx/foo etc.
    
    Cc: qemu-stable@nongnu.org
    Reviewed-by: John Snow <jsnow@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 24, 2015
  2. qtest: Add qtest_add() wrapper macro

    It extends g_test_add() macro with the architecture path.
    
    Reviewed-by: John Snow <jsnow@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 25, 2015
  3. qtest: Add qtest_add_data_func() wrapper function

    It calls g_test_add_data_func() with a path supplemented by the
    architecture, like qtest_add_func() does.
    
    Reviewed-by: John Snow <jsnow@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 24, 2015
  4. fw_cfg-test: Fix test path to include architecture

    Use qtest_add_func() instead of g_test_add_func() to reflect
    the architecture tested, changing GTester paths as follows:
    
      /fw_cfg/foo -> /x86_64/fw_cfg/foo etc.
    
    Cc: qemu-stable@nongnu.org
    Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 19, 2015
Commits on Mar 17, 2015
  1. tests: Add PC CPU test

    Test non-default -smp core and thread counts and a non-default CPU model
    on all PC machines except for isapc. Note that not all historic versions
    actually supported this particular configuration, ignored for simplicity.
    
    For machines pc-*-1.5+ test QMP cpu-add with monotonically increasing ID,
    and test for graceful failure otherwise.
    
    Cc: Eduardo Habkost <ehabkost@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 13, 2015
  2. pc: Suppress APIC ID compatibility warning for QTest

    This avoids cluttering GTester output with irrelevant warnings.
    
    Cc: Eduardo Habkost <ehabkost@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 14, 2015
  3. qdev: Move owner-less IRQs to /machine/unattached

    Move non-qdev-gpio[*] from /machine into /machine/unattached.
    For the PC this moves 25 nodes from the stable namespace into the unstable.
    
    Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Tested-by: Alistair Francis <alistair.francis@xilinx.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 12, 2015
  4. memory: Move owner-less MemoryRegions to /machine/unattached

    This cleans up the official /machine namespace. In particular
    /machine/system[0] and /machine/io[0], as well as entries with
    non-sanitized node names such as "/machine/qemu extended regs[0]".
    
    The actual MemoryRegion names remain unchanged.
    
    Acked-by: Paolo Bonzini <pbonzini@redhat.com>
    Tested-by: Alistair Francis <alistair.francis@xilinx.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Mar 12, 2015
  5. qom: Implement info qom-tree HMP command

    To complement qdev's bus-oriented info qtree, info qom-tree
    prints a hierarchical view of the QOM composition tree.
    
    By default, the machine composition tree is shown. This can be overriden
    by supplying a path argument, such as "info qom-tree /".
    
    Tested-by: Alistair Francis <alistair.francis@xilinx.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed May 7, 2014
  6. qom: Implement qom-set HMP command

    Re-implemented based on qmp_qom_set() to facilitate argument parsing.
    
    Warn about ambiguous path arguments.
    
    Reviewed-by: Gonglei <arei.gonglei@huawei.com>
    Tested-by: Alistair Francis <alistair.francis@xilinx.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed May 7, 2014
  7. qom: Implement qom-list HMP command

    Implement it as a wrapper for QMP qom-list, but mimic the behavior of
    scripts/qmp/qom-list in making the path argument optional and listing
    the root if absent, to hint users what kind of path to pass.
    
    Reviewed-by: Gonglei <arei.gonglei@huawei.com>
    Tested-by: Alistair Francis <alistair.francis@xilinx.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed May 7, 2014
  8. scripts: Add qom-tree script

    Functionally it is a recursive qom-list with qom-get per non-child<>
    property. Some failures needed to be handled, such as trying to read a
    pointer property, which is not representable in QMP. Those print a
    literal "<EXCEPTION>".
    
    Tested-by: Alistair Francis <alistair.francis@xilinx.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Feb 5, 2014
Commits on Oct 31, 2014
  1. ivshmem: Fix fd leak on error

    Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    afaerber committed with bonzini Sep 15, 2014
Commits on Sep 4, 2014
  1. machine: Clean up -machine handling

    Since commit c4090f8, -object options are no longer handled through
    object_set_property(), so clean up -object leftovers by renaming the
    function and dropping special-casing of qom-type and id properties.
    
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    afaerber committed Jul 23, 2014
Commits on Jul 18, 2014
  1. module: Don't complain when a module is absent

    The current implementation depends on a configure-time generated list of
    block modules. When any of them is absent, module_load() emits a warning.
    
    This is suboptimal because extracting code to modules was mainly done to
    allow separate packaging of modules with intrusive dependencies. Absence
    of optional packages then leads to absence of modules and an error
    message, which users may recognize as new and report as error.
    
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Cc: Michael Tokarev <mjt@tls.msk.ru>
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    afaerber committed with bonzini Jul 15, 2014
  2. module: Simplify module_load()

    The file path is not used for error reporting, so we can free it
    directly after use.
    
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    afaerber committed with bonzini Jul 15, 2014
Commits on Jul 15, 2014
  1. libqos: Fix PC PCI endianness glitches

    The libqos implementation of io_read{b,w,l} and io_write{b,w,l} hooks
    was relying on qtest_mem{read,write}() respectively. With d81d410 (usb:
    improve ehci/uhci test) this resulted in assertion failures on ppc hosts:
    
     ERROR:tests/usb-hcd-ehci-test.c:78:ehci_port_test: assertion failed: ((value & mask) == (expect & mask))
    
     ERROR:tests/usb-hcd-ehci-test.c:128:pci_uhci_port_2: assertion failed: (pcibus != NULL)
    
     ERROR:tests/usb-hcd-ehci-test.c:150:pci_ehci_port_2: assertion failed: (pcibus != NULL)
    
    qtest_read{b,w,l,q}() and qtest_write{b,w,l,q}() had been introduced
    as endian-safe replacement for qtest_mem{read,write}() in I2C in
    872536b (qtest: Add MMIO support). Use them for PCI as well.
    
    Cc: Anthony Liguori <aliguori@amazon.com>
    Cc: Gerd Hoffmann <kraxel@redhat.com>
    Fixes: c4efe1c qtest: add libqos including PCI support
    Fixes: d81d410 usb: improve ehci/uhci test
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    afaerber committed with pm215 Jul 14, 2014
Commits on Jul 14, 2014
  1. tests: Fix unterminated string output visitor enum human string

    The buffer was being allocated of size string length plus two.
    Around the string two quotes were being added, but no terminating NUL.
    It was then compared using g_assert_cmpstr(), resulting in fairly random
    assertion failures:
    
     ERROR:tests/test-string-output-visitor.c:213:test_visitor_out_enum: assertion failed (str == str_human): ("\"value1\"" == "\"value1\"\001EEEEEEEEEEEEEE\0171")
    
    There is no g_assert_cmpnstr() counterpart, so use g_strdup_printf()
    for safely assembling the string in the first place.
    
    Cc: Hu Tao <hutao@cn.fujitsu.com>
    Cc: Michael S. Tsirkin <mst@redhat.com>
    Suggested-by: Eric Blake <eblake@redhat.com>
    Fixes: b4900c0 tests: add human format test for string output visitor
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    afaerber committed with Kevin Wolf Jul 9, 2014