Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: qemu/qemu
base: 1488ccb9b64e
Choose a base ref
...
head repository: qemu/qemu
compare: f6b761bdbd8b
Choose a head ref
  • 7 commits
  • 5 files changed
  • 5 contributors

Commits on May 4, 2023

  1. qga/linux: add usb support to guest-get-fsinfo

    Signed-off-by: Kfir Manor <kfir@daynix.com>
    Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    kfir-manor authored and kostyanf14 committed May 4, 2023
    Copy the full SHA
    5a954e0 View commit details
    Browse the repository at this point in the history
  2. qga: Refactor guest-exec capture-output to take enum

    Previously capture-output was an optional boolean flag that either
    captured all output or captured none. While this is OK in most cases, it
    lacks flexibility for more advanced capture cases, such as wanting to
    only capture stdout.
    
    This commits refactors guest-exec qapi to take an enum for capture mode
    instead while preserving backwards compatibility.
    
    Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
    Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
    Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    danobi authored and kostyanf14 committed May 4, 2023
    Copy the full SHA
    9c5ccc5 View commit details
    Browse the repository at this point in the history
  3. qga: Add merged variant to GuestExecCaptureOutputMode

    Currently, any captured output (via `capture-output`) is segregated into
    separate GuestExecStatus fields (`out-data` and `err-data`). This means
    that downstream consumers have no way to reassemble the captured data
    back into the original stream.
    
    This is relevant for chatty and semi-interactive (ie. read only) CLI
    tools.  Such tools may deliberately interleave stdout and stderr for
    visual effect. If segregated, the output becomes harder to visually
    understand.
    
    This commit adds a new enum variant to the GuestExecCaptureOutputMode
    qapi to merge the output streams such that consumers can have a pristine
    view of the original command output.
    
    Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
    Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    danobi authored and kostyanf14 committed May 4, 2023
    Copy the full SHA
    810f677 View commit details
    Browse the repository at this point in the history
  4. qga: test: Add tests for merged flag

    This commit adds a test to ensure `merged` functions as expected.
    We also add a negative test to ensure we haven't regressed previous
    functionality.
    
    Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
    Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    danobi authored and kostyanf14 committed May 4, 2023
    Copy the full SHA
    c7d74f2 View commit details
    Browse the repository at this point in the history
  5. qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601

    All current versions of glib require _WIN32_WINNT set to 0x0601
    or higher already, and we also use this value as a minimum in our
    osdep.h header file, so there is no way to still compile this code
    with an older version of the Windows ABI. Thus we can drop this
    check now.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
    Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    huth authored and kostyanf14 committed May 4, 2023
    Copy the full SHA
    8cc28cb View commit details
    Browse the repository at this point in the history
  6. qga: Fix suspend on Linux guests without systemd

    Allow the Linux guest agent to attempt each of the suspend methods
    (systemctl, pm-* and writing to /sys) in turn.
    
    Prior to this guests without systemd failed to suspend due to
    `guest_suspend` returning early regardless of the return value of
    `systemd_supports_mode`.
    
    Signed-off-by: Mark Somerville <mark@qpok.net>
    Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
    Mark Somerville authored and kostyanf14 committed May 4, 2023
    Copy the full SHA
    86dcb6a View commit details
    Browse the repository at this point in the history
  7. Merge tag 'qga-pull-2023-05-04' of https://github.com/kostyanf14/qemu

    …into staging
    
    qga-pull-2023-05-04
    
    # -----BEGIN PGP SIGNATURE-----
    #
    # iQIzBAABCgAdFiEEwsLBCepDxjwUI+uE711egWG6hOcFAmRTf4EACgkQ711egWG6
    # hOdczhAAoMkw/bWZtpiEmeLIcliNVuF3gzouHRp2sBFeHCUtaE2jzmriuy4QqH81
    # G+kgqdEogqv7G5Qq2LXNcbSl76eZnKbumtlj+N4XIDoukPWUmItIjuM9NYM0U84Y
    # DAsj6o8Kw1W+GMBmk6AuLFNYMwv41GS6RyvH/daeYEGmFf0jYIARpeldTUxkxY86
    # dfEylVPBfLjkctKfgl0h5GzRkYjmxyeisyigx4Wk8sVLvz5LLXx27sFVZ7//Rn16
    # 7Ca88kzF9SUenF+ulV0HmVgR02b69w74izVII/Hh3pPkv4T2m98DeXlnHdyuc3Lb
    # bWggM2pf1Yr/jUOPtscQ9IqKTdYTLKqaErVSQJYabG9lLXRerXLj8mhH/W070jzT
    # hZwp+5VJzF/OykiM0PW/tI5a0Upg8/8w/LRPwuqP0nFsW5QYdAQXSFbtsUfVdPlE
    # Htk66xoQTLJ2a38m5WCvaRL97psGHmVXuWq0VUByNCAlWv6EiAAbTZBimIo4FZj+
    # Ps6e7Tnvhv5kai2qZ4ijxJq88n9/mv8t0s/oD/BoGQMXmNn+87bR18byY5NZWi/4
    # CKk60zbmgo8fGZ/zzwk4T+48I3SLfM+wnHePYs8nrHgoqGVEUXsCdXUYifxIcpel
    # Vnb1OHXN3n+U8LnleQ158oQcSVFicvwQMBkzM+mW16WMQlReRRM=
    # =GvNm
    # -----END PGP SIGNATURE-----
    # gpg: Signature made Thu 04 May 2023 10:48:49 AM BST
    # gpg:                using RSA key C2C2C109EA43C63C1423EB84EF5D5E8161BA84E7
    # gpg: Good signature from "Kostiantyn Kostiuk (Upstream PR sign) <kkostiuk@redhat.com>" [unknown]
    # gpg: WARNING: This key is not certified with a trusted signature!
    # gpg:          There is no indication that the signature belongs to the owner.
    # Primary key fingerprint: C2C2 C109 EA43 C63C 1423  EB84 EF5D 5E81 61BA 84E7
    
    * tag 'qga-pull-2023-05-04' of https://github.com/kostyanf14/qemu:
      qga: Fix suspend on Linux guests without systemd
      qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601
      qga: test: Add tests for `merged` flag
      qga: Add `merged` variant to GuestExecCaptureOutputMode
      qga: Refactor guest-exec capture-output to take enum
      qga/linux: add usb support to guest-get-fsinfo
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
    rth7680 committed May 4, 2023
    Copy the full SHA
    f6b761b View commit details
    Browse the repository at this point in the history