Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: qemu/qemu
base: 19200a0edf67
Choose a base ref
...
head repository: qemu/qemu
compare: c7d0bdda21c3
Choose a head ref
  • 6 commits
  • 12 files changed
  • 3 contributors

Commits on May 17, 2023

  1. qapi: Improve error message for description following section 

    The error message is bad when the section is untagged.  For instance,
test case doc-interleaved-section produces "'@foobar:' can't follow
'Note' section", which is okay, but if we drop the "Note:" tag, we get
"'@foobar:' can't follow 'None' section, which is bad.

Change the error message to "description of '@foobar:' follows a
section".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230510141637.3685080-1-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
[Conflict with commit 3e32dca resolved]
    Markus Armbruster committed May 17, 2023
    Copy the full SHA
    13b392c View commit details
    Browse the repository at this point in the history

  2. docs/interop: Convert qmp-spec.txt to rST 

    Convert the qmp-spec.txt document to restructuredText.
Notable points about the conversion:
 * numbers at the start of section headings are removed, to match
   the style of the rest of the manual
 * cross-references to other sections or documents are hyperlinked
 * various formatting tweaks (notably the examples, which need the
   -> and <- prefixed so the QMP code-block lexer will accept them)
 * English prose fixed in a few places

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20230515162245.3964307-2-peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
    @pm215
    pm215 authored and Markus Armbruster committed May 17, 2023
    Copy the full SHA
    a5392fa View commit details
    Browse the repository at this point in the history

  3. docs/interop/qmp-spec: Update error description for parsing errors 

    The description text for a parsing error has changed since the
spec doc was first written; update the example in the docs.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20230515162245.3964307-3-peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
    @pm215
    pm215 authored and Markus Armbruster committed May 17, 2023
    Copy the full SHA
    da91a50 View commit details
    Browse the repository at this point in the history

  4. docs/interop: Delete qmp-intro.txt 

    qmp-intro.txt is quite small and provides very little information
that isn't already in the documentation elsewhere.  Fold the example
command lines into qemu-options.hx, and delete the now-unneeded plain
text document.

While we're touching the qemu-options.hx documentation text,
wordsmith it a little bit and improve the rST formatting.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20230515162245.3964307-4-peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
    @pm215
    pm215 authored and Markus Armbruster committed May 17, 2023
    Copy the full SHA
    a729c0c View commit details
    Browse the repository at this point in the history

  5. qapi/parser: Drop two bad type hints for now 

    Two type hints fail centos-stream-8-x86_64 CI.  They are actually
broken.  Changing them to Optional[re.Match[str]] fixes them locally
for me, but then CI fails differently.  Drop them for now.

Fixes: 3e32dca (qapi: Rewrite parsing of doc comment section symbols and tags)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230517061600.1782455-1-armbru@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Igor Mammedov <imammedo@redhat.com>
    Markus Armbruster committed May 17, 2023
    Copy the full SHA
    28d2a4f View commit details
    Browse the repository at this point in the history

  6. Merge tag 'pull-qapi-2023-05-17' of https://repo.or.cz/qemu/armbru in… 

    …to staging

QAPI patches patches for 2023-05-17

# -----BEGIN PGP SIGNATURE-----
#
# iQJGBAABCAAwFiEENUvIs9frKmtoZ05fOHC0AOuRhlMFAmRk24kSHGFybWJydUBy
# ZWRoYXQuY29tAAoJEDhwtADrkYZTFKMP/isne+7NXJHeiXktbODgegKlshzaT2eq
# K+NUh0UDWVpV2h46c7PjZmwBO2iTwLZPReI1TY8Jghf9fmzrW0d0+oz9+L1ZxzrY
# ScKq0ThnjMJqXifxeIe4hExfHCDcSu8WHOHwNVRVy4Kqrn1fEivilYigTOGFljCb
# H7nuszJTGPcM80ncA5JY+R3+tng54YpMjOLaM8kXpy8PHPs3dSVq9bYtWuiHBPVl
# htYPix8QK0rMAzPquLHm7bBse9IWHowrzZuoKvMgBoeAUKXBJYkyo9MoDBNOI2+x
# 8PkEjFRJYkr+RM6LF4niM+bvTypbSwF8Y6vUqJtc0jkCTzAnkRh9YXVPbhr6OgS0
# fdOQz/ag4LJ6jyeATTLuxm3xa+yp4dv+if6G2Bgw3RCCuzStZvdGqYJ0/oENpHf6
# +MqDgWf1Df75VjOSdnj7jfDLGCZopNYkXz0arS8jv0TMNfunEj44v3wzJK2duVLP
# lkM86falSdbgct/KEn1ceIXG3gX21yIlpRpLTTFERyoVYVGAP2ac83djjsV/02Vk
# 8psixHWlj/aVAgVOn2ljo5yuoO5Xj5L6XUeObavRMmDtHj83X4emDEfHtxQRU6Ug
# EWTt7sA/7Z2I0MdDvgOOYRyAT1jMnTqZV/r7nPhwOxd5sFXso3IkCvQ3wqPvgzje
# H7d6sCaoZd9N
# =np3P
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 17 May 2023 06:50:01 AM PDT
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [undefined]
# gpg:                 aka "Markus Armbruster <armbru@pond.sub.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* tag 'pull-qapi-2023-05-17' of https://repo.or.cz/qemu/armbru:
  qapi/parser: Drop two bad type hints for now
  docs/interop: Delete qmp-intro.txt
  docs/interop/qmp-spec: Update error description for parsing errors
  docs/interop: Convert qmp-spec.txt to rST
  qapi: Improve error message for description following section

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
    @rth7680
    rth7680 committed May 17, 2023
    Copy the full SHA
    c7d0bdd View commit details
    Browse the repository at this point in the history