Commits on Jun 28, 2023

1. hw/nvme: add comment for nvme-ns properties …

   Add more comments of existing properties for nvme-ns device.
   
   Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
   Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
   Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

   

   minwooim authored and birkelund committed Jun 28, 2023
   Copy the full SHA

   7491e0e View commit details

   Browse the repository at this point in the history

2. hw/nvme: consider COPY command in nvme_aio_err …

   If we don't have NVME_CMD_COPY consideration in the switch statement in
   nvme_aio_err(), it will go to have NVME_INTERNAL_DEV_ERROR and
   `req->status` will be ovewritten to it.  During the aio context, it
   might set the NVMe status field like NVME_CMD_SIZE_LIMIT, but it's
   overwritten in the nvme_aio_err().
   
   Add consideration for the NVME_CMD_COPY not to overwrite the status at
   the end of the function.
   
   Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
   Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
   Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

   

   minwooim authored and birkelund committed Jun 28, 2023
   Copy the full SHA

   cab1da5 View commit details

   Browse the repository at this point in the history

3. hw/nvme: check maximum copy length (MCL) for COPY …

   MCL(Maximum Copy Length) in the Identify Namespace data structure limits
   the number of LBAs to be copied inside of the controller.  We've not
   checked it at all, so added the check with returning the proper error
   status.
   
   Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
   Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
   Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

   

   minwooim authored and birkelund committed Jun 28, 2023
   Copy the full SHA

   381ab99 View commit details

   Browse the repository at this point in the history

4. hw/nvme: fix verification of number of ruhis …

   Fix a off-by-one error when verifying the number of reclaim unit handle
   identifiers specified in fdp.ruhs. To make the fix nicer, move the
   verification of the fdp.nruh parameter to an earlier point.
   
   Fixes: 73064ed ("hw/nvme: flexible data placement emulation")
   Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
   Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

   

   birkelund committed Jun 28, 2023
   Copy the full SHA

   3ae8a54 View commit details

   Browse the repository at this point in the history

5. hw/nvme: verify uniqueness of reclaim unit handle identifiers …

   Verify that a reclaim unit handle identifier is only specified once in
   fdp.ruhs.
   
   Fixes: 73064ed ("hw/nvme: flexible data placement emulation")
   Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
   Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

   

   birkelund committed Jun 28, 2023
   Copy the full SHA

   94fa8ca View commit details

   Browse the repository at this point in the history

6. hw/nvme: add placement handle list ranges …

   Allow the placement handles to be specified as ranges, i.e.
   `fdp.ruhs=1:3-5` will attempt to assign ruh 1, 3, 4 and 5 to the
   namespace.
   
   Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
   Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

   

   birkelund committed Jun 28, 2023
   Copy the full SHA

   ce80177 View commit details

   Browse the repository at this point in the history

7. docs: update hw/nvme documentation for TP4146 …

   Update documentation for TP4146 ("Flexible Data Placement") emulation.
   
   Reviewed-by: Jesper Wendel Devantier <j.devantier@samsung.com>
   Signed-off-by: Klaus Jensen <k.jensen@samsung.com>

   

   birkelund committed Jun 28, 2023
   Copy the full SHA

   e409c90 View commit details

   Browse the repository at this point in the history

8. Merge tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu… …

   … into staging
   
   hw/nvme updates
   
   Small set of fixes and some updates for the FDP support.
   
   # -----BEGIN PGP SIGNATURE-----
   #
   # iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmSb/D4ACgkQTeGvMW1P
   # DemziAf/eQfjnVr57A+Kglf8J15MCW0GiArbHCJfcl9vf0HPP/iY1c9V4cCZjTLG
   # vkkkU6W+TFaYALGOVgAldHWC7OCpOi7GHrlqRJDuw86d2dyLDn/l+GQin/rVoocD
   # fzF2gRVQU4x9qzmjRUikVhRzZbrB4F/AH6QQ8EV3wx2wrljyusItEGe53FEuCugx
   # pwtKrG990188+UCT1ofr2JYhLq3OmYQi3o2fWgzMp9jP+NeROgKaevWG4UEhFonG
   # CdeL9BMlSRAfrdR1gTvZpG2mFsrroeBCCjXcrKSwkAxBqpMJDSLvbGqoGJo6kDWm
   # c9x82Zy2/wVuQaDk+atmcTF1+Pddgw==
   # =//ks
   # -----END PGP SIGNATURE-----
   # gpg: Signature made Wed 28 Jun 2023 11:24:14 AM CEST
   # gpg:                using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9
   # gpg: Good signature from "Klaus Jensen <its@irrelevant.dk>" [unknown]
   # gpg:                 aka "Klaus Jensen <k.jensen@samsung.com>" [unknown]
   # gpg: WARNING: This key is not certified with a trusted signature!
   # gpg:          There is no indication that the signature belongs to the owner.
   # Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468  4272 63D5 6FC5 E55D A838
   #      Subkey fingerprint: 5228 33AA 75E2 DCE6 A247  66C0 4DE1 AF31 6D4F 0DE9
   
   * tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu:
     docs: update hw/nvme documentation for TP4146
     hw/nvme: add placement handle list ranges
     hw/nvme: verify uniqueness of reclaim unit handle identifiers
     hw/nvme: fix verification of number of ruhis
     hw/nvme: check maximum copy length (MCL) for COPY
     hw/nvme: consider COPY command in nvme_aio_err
     hw/nvme: add comment for nvme-ns properties
   
   Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

   

   rth7680 committed Jun 28, 2023
   Copy the full SHA

   aa1048e View commit details

   Browse the repository at this point in the history