Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: qemu/qemu
base: cab35c73be9d
Choose a base ref
...
head repository: qemu/qemu
compare: c5ffd16ba4c8
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Jun 20, 2023

  1. target/hppa: New SeaBIOS-hppa version 7

    Update SeaBIOS-hppa to version 7 which fixes a boot problem
    with Debian-12 install CD images.
    
    The problem with Debian-12 is, that the ramdisc got bigger
    than what the firmware could load in one call to the LSI
    scsi driver.
    
    Signed-off-by: Helge Deller <deller@gmx.de>
    hdeller committed Jun 20, 2023
    Copy the full SHA
    bb9c998 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge tag 'seabios-hppa-v7-pull-request' of https://github.com/hdelle…

    …r/qemu-hppa into staging
    
    hppa: New SeaBIOS-hppa version 7 ROM
    
    New SeaBIOS-hppa version 7 ROM to fix Debian-12
    CD-ROM boot issues.
    
    Signed-off-by: Helge Deller <deller@gmx.de>
    
    # -----BEGIN PGP SIGNATURE-----
    #
    # iHUEABYKAB0WIQS86RI+GtKfB8BJu973ErUQojoPXwUCZJIExQAKCRD3ErUQojoP
    # XypaAP9j0YWdl1ovPiyw8fTdY5U6yCKGIjqtkXzk4egPbzkU1AD7BxMY+GbDSKv8
    # Lt9K+R4cu0EVxfYsz17e780wSMLPcwc=
    # =M8NU
    # -----END PGP SIGNATURE-----
    # gpg: Signature made Tue 20 Jun 2023 09:57:57 PM CEST
    # gpg:                using EDDSA key BCE9123E1AD29F07C049BBDEF712B510A23A0F5F
    # gpg: Good signature from "Helge Deller <deller@gmx.de>" [unknown]
    # gpg:                 aka "Helge Deller <deller@kernel.org>" [unknown]
    # gpg: WARNING: This key is not certified with a trusted signature!
    # gpg:          There is no indication that the signature belongs to the owner.
    # Primary key fingerprint: 4544 8228 2CD9 10DB EF3D  25F8 3E5F 3D04 A7A2 4603
    #      Subkey fingerprint: BCE9 123E 1AD2 9F07 C049  BBDE F712 B510 A23A 0F5F
    
    * tag 'seabios-hppa-v7-pull-request' of https://github.com/hdeller/qemu-hppa:
      target/hppa: New SeaBIOS-hppa version 7
    
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
    rth7680 committed Jun 21, 2023
    Copy the full SHA
    2346098 View commit details
    Browse the repository at this point in the history
  2. Revert "cputlb: Restrict SavedIOTLB to system emulation"

    This reverts commit d7ee93e.
    
    That commit tries to make a field in the CPUState struct not be
    present when CONFIG_USER_ONLY is set.  Unfortunately, you can't
    conditionally omit fields in structs like this based on ifdefs that
    are set per-target.  If you try it, then code in files compiled
    per-target (where CONFIG_USER_ONLY is or can be set) will disagree
    about the struct layout with files that are compiled once-only (where
    this kind of ifdef is never set).
    
    This manifests specifically in 'make check-tcg' failing, because code
    in cpus-common.c that sets up the CPUState::cpu_index field puts it
    at a different offset from the code in plugins/core.c in
    qemu_plugin_vcpu_init_hook() which reads the cpu_index field.  The
    latter then hits an assert because from its point of view every
    thread has a 0 cpu_index. There might be other weird behaviour too.
    
    Mostly we catch this kind of bug because the CONFIG_whatever is
    listed in include/exec/poison.h and so the reference to it in
    build-once source files will then cause a compiler error.
    Unfortunately CONFIG_USER_ONLY is an exception to that: we have some
    places where we use it in "safe" ways in headers that will be seen by
    once-only source files (e.g.  ifdeffing out function prototypes) and
    it would be a lot of refactoring to be able to get to a position
    where we could poison it.  This leaves us in a "you have to be
    careful to walk around the bear trap" situation...
    
    Fixes: d7ee93e ("cputlb: Restrict SavedIOTLB to system emulation")
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    Message-Id: <20230620175712.1331625-1-peter.maydell@linaro.org>
    Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
    pm215 authored and rth7680 committed Jun 21, 2023
    Copy the full SHA
    c5ffd16 View commit details
    Browse the repository at this point in the history