Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: qemu/qemu
base: dabb4183d17d
Choose a base ref
...
head repository: qemu/qemu
compare: f7f686b61cf7
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on May 29, 2023

  1. block/export: Fix null pointer dereference in error path 

    There are some error paths in blk_exp_add() that jump to 'fail:' before
'exp' is even created. So we can't just unconditionally access exp->blk.

Add a NULL check, and switch from exp->blk to blk, which is available
earlier, just to be extra sure that we really cover all cases where
BlockDevOps could have been set for it (in practice, this only happens
in drv->create() today, so this part of the change isn't strictly
necessary).

Fixes: Coverity CID 1509238
Fixes: de79b52
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230510203601.418015-3-kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit a184563)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
    Kevin Wolf authored and Michael Tokarev committed May 29, 2023
    Copy the full SHA
    bea933e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Update version for 8.0.2 release 

    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
    Michael Tokarev committed May 30, 2023
    Copy the full SHA
    f7f686b View commit details
    Browse the repository at this point in the history