Commits on Jun 30, 2023

1. vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices …

   QEMU does not emulate it so it must be disabled as long as the backend
   does not support it.
   
   Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
   Message-Id: <20230602173328.1917385-1-eperezma@redhat.com>
   Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
   Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
   Acked-by: Jason Wang <jasowang@redhat.com>
   Tested-by: Lei Yang <leiyang@redhat.com>
   (cherry picked from commit 51e8424)
   Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

   

   eugpermar authored and Michael Tokarev committed Jun 30, 2023
   Copy the full SHA

   78c4994 View commit details

   Browse the repository at this point in the history

2. target/ppc: Fix decrementer time underflow and infinite timer loop …

   It is possible to store a very large value to the decrementer that it
   does not raise the decrementer exception so the timer is scheduled, but
   the next time value wraps and is treated as in the past.
   
   This can occur if (u64)-1 is stored on a zero-triggered exception, or
   (u64)-1 is stored twice on an underflow-triggered exception, for
   example.
   
   If such a value is set in DECAR, it gets stored to the decrementer by
   the timer function, which then immediately causes another timer, which
   hangs QEMU.
   
   Clamp the decrementer to the implemented width, and use that as the
   value for the timer calculation, effectively preventing this overflow.
   
   Reported-by: sdicaro@DDCI.com
   Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
   Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
   Message-Id: <20230530131214.373524-1-npiggin@gmail.com>
   Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
   (cherry picked from commit 09d2db9)
   Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

   

   npiggin authored and Michael Tokarev committed Jun 30, 2023
   Copy the full SHA

   4d8459c View commit details

   Browse the repository at this point in the history

3. vfio/pci: Fix a segfault in vfio_realize …

   The kvm irqchip notifier is only registered if the device supports
   INTx, however it's unconditionally removed in vfio realize error
   path. If the assigned device does not support INTx, this will cause
   QEMU to crash when vfio realize fails. Change it to conditionally
   remove the notifier only if the notify hook is setup.
   
   Before fix:
   (qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,xres=1
   Connection closed by foreign host.
   
   After fix:
   (qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,xres=1
   Error: vfio 0000:81:11.1: xres and yres properties require display=on
   (qemu)
   
   Fixes: c5478fe ("vfio/pci: Respond to KVM irqchip change notifier")
   Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
   Reviewed-by: Cédric Le Goater <clg@redhat.com>
   Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
   Signed-off-by: Cédric Le Goater <clg@redhat.com>
   (cherry picked from commit 357bd79)
   Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

   

   duanzhenzhong authored and Michael Tokarev committed Jun 30, 2023
   Copy the full SHA

   c7b6b70 View commit details

   Browse the repository at this point in the history

4. vfio/pci: Call vfio_prepare_kvm_msi_virq_batch() in MSI retry path …

   When vfio_enable_vectors() returns with less than requested nr_vectors
   we retry with what kernel reported back. But the retry path doesn't
   call vfio_prepare_kvm_msi_virq_batch() and this results in,
   
   qemu-system-aarch64: vfio: Error: Failed to enable 4 MSI vectors, retry with 1
   qemu-system-aarch64: ../hw/vfio/pci.c:602: vfio_commit_kvm_msi_virq_batch: Assertion `vdev->defer_kvm_irq_routing' failed
   
   Fixes: dc580d5 ("vfio: defer to commit kvm irq routing when enable msi/msix")
   Reviewed-by: Longpeng <longpeng2@huawei.com>
   Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
   Reviewed-by: Cédric Le Goater <clg@redhat.com>
   Signed-off-by: Cédric Le Goater <clg@redhat.com>
   (cherry picked from commit c174088)
   Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

   

   shamiali2008 authored and Michael Tokarev committed Jun 30, 2023
   Copy the full SHA

   3b1b9aa View commit details

   Browse the repository at this point in the history