Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fit segement size explanation #4250

Closed
wants to merge 7 commits into from
@@ -215,7 +215,7 @@ Other than the grid type, you can define:
* the :guilabel:`Interval` between two consecutive grid references in ``X``
and ``Y`` directions;
* the :guilabel:`Interval Units` to use for the grid references, in ``Map
units``, ``Millimeters`` or ``Centimeters``;
units``, ``Fit Segement Width``, ``Millimeters`` or ``Centimeters`` *(`Fix Segement Width` will dynamically select the grid interval based on the map extent to a "pretty" interval)*;
This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@DelazJ

DelazJ Sep 21, 2019

Contributor

Typo. And how about adding this new option at the end of the list (the parenthesis would then directly be with the concerned option, eg

Suggested change
units``, ``Fit Segement Width``, ``Millimeters`` or ``Centimeters`` *(`Fix Segement Width` will dynamically select the grid interval based on the map extent to a "pretty" interval)*;
units``, ``Millimeters``, ``Centimeters`` or ``Fit Segment Width`` *(``Fit Segment Width`` will dynamically select the grid interval based on the map extent to a "pretty" interval)*;

andwe could then replace the second "fit segment width" with "the latter option"?

Just some formatting recommendations to keep in mind:

  • the backtick character (`) needs to be doubled to render in html
  • try to have lines no longer than 80 characters, easier to read on some devices and to comment

This comment has been minimized.

Copy link
@nickbearman

nickbearman Sep 21, 2019

Author Contributor

Thanks, yes this makes sense. I had Fit Segement Width second because that was how it was listed in the dialog.
Thanks also for typo notes

* an :guilabel:`Offset` from the map item edges, in ``X`` and ``Y`` directions;
This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@DelazJ

DelazJ Sep 21, 2019

Contributor

the "fit segment width" triggers a min/max interval widget in replacement to x/y. Worth mentioning imho.

This comment has been minimized.

Copy link
@nickbearman

nickbearman Sep 21, 2019

Author Contributor

Thanks. If I am adding this as well about the min/max interval, is it ok to put it in the brackets, or should I add another bullet point?

This comment has been minimized.

Copy link
@DelazJ

DelazJ Sep 21, 2019

Contributor

sorry, I mixed the items since there are x/y mentioned here but, yes the min max values have to be linked with the previous bullet point, in the brackets (or we can add a full sentence in replacement of the brackets. At your convenience)

This comment has been minimized.

Copy link
@nickbearman

nickbearman Sep 21, 2019

Author Contributor

Great stuff, thanks, that makes sense. Will have a go.

* and the :guilabel:`Blend mode` of the grid (see :ref:`blend-modes`) when
compatible.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.