Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify text explaining changing to a different CRS for a grid #4252

Merged
merged 12 commits into from
Oct 10, 2019

Conversation

nickbearman
Copy link
Contributor

Since I was working in this file, I have also updated the text explaining how to change the grid to a different CRS to the project CRS.

Goal:

Ticket(s): #

  • Backport to LTR documentation is required

Copy link
Contributor Author

@nickbearman nickbearman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been on a different branch. Sorry. Still needs to be corrected though!

@nickbearman
Copy link
Contributor Author

I think I have my head around branches now! :-)

Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions.

nickbearman and others added 2 commits September 22, 2019 11:40
…_map.rst


Clarify text

Co-Authored-By: Håvard Tveite <havard.tveite@nmbu.no>
@nickbearman
Copy link
Contributor Author

I think this is good to go. @havatv thanks for your suggestions, are you happy with this?
If so, I am happy for this to be merged.

Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks fine. I have a few comments.

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remaining typo.
I would like to merge and reduce PR queue. This PR contains changes in #4250. Should I close that one?

nickbearman and others added 2 commits October 10, 2019 19:30
…_map.rst

Co-Authored-By: Håvard Tveite <havard.tveite@nmbu.no>
…_map.rst

Co-Authored-By: Harrissou Sant-anna <delazj@gmail.com>
@nickbearman
Copy link
Contributor Author

I think we are all set now. Not sure why #4250 was separate. As long as all the changes are here, happy for that to be closed.
Sorry not not responding sooner.

@DelazJ DelazJ merged commit 7d4dec6 into qgis:master Oct 10, 2019
@DelazJ DelazJ mentioned this pull request Oct 10, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants