Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify text explaining changing to a different CRS for a grid #4252

Merged
merged 12 commits into from Oct 10, 2019

Conversation

@nickbearman
Copy link
Contributor

nickbearman commented Sep 21, 2019

Since I was working in this file, I have also updated the text explaining how to change the grid to a different CRS to the project CRS.

Goal:

Ticket(s): #

  • Backport to LTR documentation is required
nickbearman and others added 6 commits Sep 21, 2019
…_map.rst

Co-Authored-By: Harrissou Sant-anna <delazj@gmail.com>
Merge branch 'nickbearman-4166' of https://github.com/nickbearman/QGIS-Documentation into nickbearman-4166
Copy link
Contributor Author

nickbearman left a comment

This should have been on a different branch. Sorry. Still needs to be corrected though!

@nickbearman

This comment has been minimized.

Copy link
Contributor Author

nickbearman commented Sep 21, 2019

I think I have my head around branches now! :-)

nickbearman and others added 2 commits Sep 22, 2019
…_map.rst


Clarify text

Co-Authored-By: Håvard Tveite <havard.tveite@nmbu.no>
@nickbearman

This comment has been minimized.

Copy link
Contributor Author

nickbearman commented Oct 5, 2019

I think this is good to go. @havatv thanks for your suggestions, are you happy with this?
If so, I am happy for this to be merged.

Copy link
Contributor

havatv left a comment

Thanks. This looks fine. I have a few comments.

Copy link
Contributor

DelazJ left a comment

Some remaining typo.
I would like to merge and reduce PR queue. This PR contains changes in #4250. Should I close that one?

nickbearman and others added 2 commits Oct 10, 2019
…_map.rst

Co-Authored-By: Håvard Tveite <havard.tveite@nmbu.no>
…_map.rst

Co-Authored-By: Harrissou Sant-anna <delazj@gmail.com>
@nickbearman

This comment has been minimized.

Copy link
Contributor Author

nickbearman commented Oct 10, 2019

I think we are all set now. Not sure why #4250 was separate. As long as all the changes are here, happy for that to be closed.
Sorry not not responding sooner.

@DelazJ DelazJ merged commit 7d4dec6 into qgis:master Oct 10, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DelazJ DelazJ referenced this pull request Oct 10, 2019
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.