Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify text explaining changing to a different CRS for a grid #4252

Merged
merged 12 commits into from Oct 10, 2019

Update line endings

  • Loading branch information
nickbearman committed Sep 21, 2019
commit 4d9c141555ab4a56f54e9b0c24fecb1ce7b2e69d
@@ -214,7 +214,6 @@ Other than the grid type, you can define:
* the :guilabel:`CRS` which could be set differently to the project CRS;
This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@havatv

havatv Sep 21, 2019

Contributor
Suggested change
* the :guilabel:`CRS` which could be set differently to the project CRS;
* the :guilabel:`CRS` which could be different from the project CRS;

This comment has been minimized.

Copy link
@nickbearman

nickbearman Sep 22, 2019

Author Contributor

Thanks @havatv I like this suggestion.

* the :guilabel:`Interval` between two consecutive grid references in ``X``
and ``Y`` directions;
* the :guilabel:`Interval Units` to use for the grid references, in ``Map
* the :guilabel:`Interval Units` to use for the grid references, in ``Map
This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@havatv

havatv Sep 21, 2019

Contributor

Interval units appears before Interval in the user interface. Should also be moved up here?

This comment has been minimized.

Copy link
@nickbearman

nickbearman Oct 5, 2019

Author Contributor

Yes, agreed.

This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@havatv

havatv Sep 21, 2019

Contributor
Suggested change
* the :guilabel:`Interval Units` to use for the grid references, in ``Map
* the :guilabel:`Interval units` to use for the grid references, in ``Map
Unit``, ``Fit Segment Width``, ``Millimeter`` or ``Centimeter``;
This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@havatv

havatv Sep 21, 2019

Contributor
Suggested change
Unit``, ``Fit Segment Width``, ``Millimeter`` or ``Centimeter``;
unit``, ``Fit Segment Width``, ``Millimeter`` or ``Centimeter``;

This comment has been minimized.

Copy link
@havatv

havatv Sep 21, 2019

Contributor

Fit segment width does not appear here (3.4.11).

This comment has been minimized.

Copy link
@DelazJ

DelazJ Sep 21, 2019

Contributor

This is a 3.10 doc @havatv

This comment has been minimized.

Copy link
@havatv

havatv Sep 21, 2019

Contributor

Thanks for the clarification @DelazJ, and sorry for not taking the time to check with 3.10.

This comment has been minimized.

Copy link
@nickbearman

nickbearman Sep 22, 2019

Author Contributor

Thanks, am resolving this one.

* *``Fix Segment Width`` will dynamically select the grid interval based
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.