Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify text explaining changing to a different CRS for a grid #4252

Merged
merged 12 commits into from Oct 10, 2019
@@ -209,13 +209,16 @@ As grid type, you can specify to use a:
intersection;
* or *Frame and annotations only*.

Other than the grid type, you can define:
Other than the grid type, you can define:

* the :guilabel:`CRS` which could not be the same as the map item's;
* the :guilabel:`CRS` which could be different from the project CRS;
* the :guilabel:`Interval units` to use for the grid references, in ``Map
Unit``, ``Fit Segment Width``, ``Millimeter`` or ``Centimeter``;
* the :guilabel:`Interval` between two consecutive grid references in ``X``
and ``Y`` directions;
* the :guilabel:`Interval Units` to use for the grid references, in ``Map
units``, ``Millimeters`` or ``Centimeters``;
* choosing ``Fix Segment Width`` will dynamically select the grid interval based
This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@DelazJ

DelazJ Oct 10, 2019

Contributor
Suggested change
* choosing ``Fix Segment Width`` will dynamically select the grid interval based
* choosing ``Fit Segment Width`` will dynamically select the grid interval based
on the map extent to a "pretty" interval. When selected, the ``Minimum`` and
``Maximum`` intervals can be set;
* an :guilabel:`Offset` from the map item edges, in ``X`` and ``Y`` directions;
This conversation was marked as resolved by nickbearman

This comment has been minimized.

Copy link
@havatv

havatv Sep 21, 2019

Contributor
Suggested change
* an :guilabel:`Offset` from the map item edges, in ``X`` and ``Y`` directions;
* the :guilabel:`Offset` from the map item edges, in the ``X`` and/or the ``Y`` direction;

This comment has been minimized.

Copy link
@nickbearman

nickbearman Sep 22, 2019

Author Contributor

I didn't review this in my original changes. How about:
Offset from the map item edges, in the X and/ or the Y directions

This comment has been minimized.

Copy link
@nickbearman

nickbearman Oct 5, 2019

Author Contributor

Looks good :-)

This comment has been minimized.

Copy link
@havatv

havatv Oct 5, 2019

Contributor

I have updated my suggestion accordingly.

This comment has been minimized.

Copy link
@DelazJ

DelazJ Oct 10, 2019

Contributor

@nickbearman You need to unresolve the discussion and commit the suggestion to get it integrated in you PR.
@havatv why is the article an removed? Makes sense to me, coherent with previous items in the list and the introductory sentence.

This comment has been minimized.

Copy link
@havatv

havatv Oct 10, 2019

Contributor

@DelazJ, it did not feel right to use "an" for offset since we are talking about offsets in both the x and the y direction (plural). But that part of my suggestion is not so important. I have modified my suggestion to start with "the" (instead of the origingal "an").

* and the :guilabel:`Blend mode` of the grid (see :ref:`blend-modes`) when
compatible.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.