Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of reselect tool #4253

Merged
merged 6 commits into from Oct 5, 2019

Conversation

@nickbearman
Copy link
Contributor

nickbearman commented Sep 21, 2019

Goal: Add text for reselect tool to user manual

Ticket(s): fix #4216

  • Backport to LTR documentation is required

Completed as a part of the FOSS4GUK 2019 code sprint

nickbearman and others added 3 commits Sep 21, 2019
…_map.rst

Co-Authored-By: Harrissou Sant-anna <delazj@gmail.com>
@DelazJ

This comment has been minimized.

Copy link
Contributor

DelazJ commented Sep 21, 2019

Remind to begin always from master when you want to address a different issue.

@nickbearman

This comment has been minimized.

Copy link
Contributor Author

nickbearman commented Sep 22, 2019

Thanks, I think I got confused with branches but think I am ok now.

@DelazJ

This comment has been minimized.

Copy link
Contributor

DelazJ commented Sep 26, 2019

@nickbearman can you revert the changes in the the map_item file? Otherwise you get in trouble with your PRs when this is merged (I assume there's no more to do with the reselect tool description)

@nickbearman

This comment has been minimized.

Copy link
Contributor Author

nickbearman commented Sep 27, 2019

Thanks, will try to when I get some time. V busy currently!

DelazJ added 2 commits Oct 1, 2019
@SrNetoChan

This comment has been minimized.

Copy link
Member

SrNetoChan commented Oct 1, 2019

Would it make sense to use a .. tip: instead of a note?

@DelazJ

This comment has been minimized.

Copy link
Contributor

DelazJ commented Oct 2, 2019

Indeed, tip could be more appropriate imho

@nickbearman

This comment has been minimized.

Copy link
Contributor Author

nickbearman commented Oct 5, 2019

Thanks @DelazJ for reverting the changes for me!

@SrNetoChan Yes I think a tip is ideal, thanks for the suggestion. I have implemented it.

@DelazJ DelazJ merged commit 90fd99a into qgis:master Oct 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.