Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QEP #6: Advanced digitizing tools #8

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@3nids
Copy link
Member

commented Oct 10, 2014

Advanced digitizing tools in QGIS application.

See pull request qgis/QGIS#1624

@NathanW2 NathanW2 changed the title QGEP #6: CAD tools QEP #6: CAD tools Nov 9, 2014

@3nids 3nids changed the title QEP #6: CAD tools QEP #8: CAD tools Dec 2, 2014

@3nids 3nids changed the title QEP #8: CAD tools QEP #6: CAD tools Dec 3, 2014

@3nids 3nids changed the title QEP #6: CAD tools QEP #6: Advanced digitizing tools Dec 3, 2014

@pcav

This comment has been minimized.

Copy link
Member

commented Dec 3, 2014

I do not see a reason why not to merge it - thanks!

@jef-n

This comment has been minimized.

Copy link
Member

commented Dec 4, 2014

Yes, why wasn't this merged already? We wasted more than a month of time to test it in master... ;)

@3nids

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2014

I couldn't rewrite the QEP before my holidays, went off 2 weeks, and...here it is...
If no objections arise by tomorrow, I would propose Nathan to put it to final draft.

@rduivenvoorde

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2014

Yes, nice!
One remark: is it fully covering the functions in the cad plugin? If so should we deprecate/remove that one then?
Or update the plugin to show a message when a user has a QGIS version which has the functions in core?

@3nids

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2014

Yes it covers all the features of the plugin, and a bit more ;)
The plugin might be deprecated whenever this reaches a stable version, but I'm not the maintainer of the plugin.

@NathanW2

This comment has been minimized.

Copy link
Member

commented Dec 7, 2014

Hey.

The main reason for having the QEP for this was to do a larger design of
the workflow if the feature was going to be in core and gui, however at the
moment the plan is to leave it in app while it gets some user testing and
so I don't see any harm in merging it as is and then creating a QEP to
think about where we can take it in the future i.e do we want the ability
to have a command like window like AutoCAD (hidden normally of course)

Thoughts?

On Thu Dec 04 2014 at 18:59:27 Denis Rouzaud notifications@github.com
wrote:

Yes it covers all the features of the plugin, and a bit more ;)
The plugin might be deprecated whenever this reaches a stable version, but
I'm not the maintainer of the plugin.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@3nids

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2014

Sounds good to me.
So, do you still want to proceed for voting the QEP or shall I merge directly the PR?

@NathanW2

This comment has been minimized.

Copy link
Member

commented Dec 9, 2014

I think just merge the PR if others are happy with that. The QEP can be
updated in future to expand the ideas more if they become part of the api.

@wonder-sk thoughts?

@jef-n

This comment has been minimized.

Copy link
Member

commented Dec 9, 2014

+1 for merging.

@wonder-sk

This comment has been minimized.

Copy link
Member

commented Dec 9, 2014

I have originally suggested Denis to write a QEP for the CAD input. It does not have any impact on core/gui library, but still it is a bigger feature (~2000 lines of new code) so I thought it would be sensible to have QEP for it that explains what is added, why, and how it works.

No problem for me to merge the work as is without a QEP though.

@NathanW2

This comment has been minimized.

Copy link
Member

commented Dec 9, 2014

Merge it.

On Tue Dec 09 2014 at 18:48:57 Martin Dobias notifications@github.com
wrote:

I have originally suggested Denis to write a QEP for the CAD input. It
does not have any impact on core/gui library, but still it is a bigger
feature (~2000 lines of new code) so I thought it would be sensible to have
QEP for it that explains what is added, why, and how it works.

No problem for me to merge the work as is without a QEP though.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@3nids

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2014

:)

@m-kuhn

This comment has been minimized.

Copy link
Member

commented May 22, 2015

Seems it's merged :)

@m-kuhn m-kuhn closed this May 22, 2015

@3nids

This comment has been minimized.

Copy link
Member Author

commented May 22, 2015

Martin wanted to keep it open as this was unfinished. But I don't mind reopening it later on.

@qgis qgis locked and limited conversation to collaborators Oct 28, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.