[Geometry checker] Fix memory corruption due to QgsGeometry deleting the passed GeometryV2 pointer when going out of scope

manisandro · manisandro · commit 01a7674f1ca8 · 2015-10-12T13:23:34.000+02:00
diff --git a/src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp b/src/plugins/geometry_checker/ui/qgsgeometrycheckerresulttab.cpp
@@ -323,7 +323,7 @@ void QgsGeometryCheckerResultTab::highlightErrors( bool current )
     if ( ui.checkBoxHighlight->isChecked() && geometry )
     {
       QgsRubberBand* featureRubberBand = new QgsRubberBand( mIface->mapCanvas() );
-      QgsGeometry geom( geometry );
+      QgsGeometry geom( geometry->clone() );
       featureRubberBand->addGeometry( &geom, mFeaturePool->getLayer() );
       featureRubberBand->setWidth( 5 );
       featureRubberBand->setColor( Qt::yellow );

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ void QgsGeometryCheckerResultTab::highlightErrors( bool current )`
`323`	`323`	`if ( ui.checkBoxHighlight->isChecked() && geometry )`
`324`	`324`	`{`
`325`	`325`	`QgsRubberBand* featureRubberBand = new QgsRubberBand( mIface->mapCanvas() );`
`326`		`- QgsGeometry geom( geometry );`
	`326`	`+ QgsGeometry geom( geometry->clone() );`
`327`	`327`	`featureRubberBand->addGeometry( &geom, mFeaturePool->getLayer() );`
`328`	`328`	`featureRubberBand->setWidth( 5 );`
`329`	`329`	`featureRubberBand->setColor( Qt::yellow );`