Add qgis_core.h to with CORE_EXPORT macro

This removes complexity from the compiler flags because defines
happen in a file.

CMakeLists.txt

@@ -581,7 +581,6 @@ ELSE (WIN32)
 
 ENDIF(WIN32)
 
-ADD_DEFINITIONS("-DCORE_EXPORT=${DLLIMPORT}")
 ADD_DEFINITIONS("-DGUI_EXPORT=${DLLIMPORT}")
 ADD_DEFINITIONS("-DPYTHON_EXPORT=${DLLIMPORT}")
 ADD_DEFINITIONS("-DANALYSIS_EXPORT=${DLLIMPORT}")
@@ -590,6 +589,7 @@ ADD_DEFINITIONS("-DCUSTOMWIDGETS_EXPORT=${DLLIMPORT}")
 ADD_DEFINITIONS("-DSERVER_EXPORT=${DLLIMPORT}")
 
 SET(CMAKE_CXX_VISIBILITY_PRESET hidden)
+INCLUDE(GenerateExportHeader)
 
 #############################################################
 # user-changeable settings which can be used to customize

python/CMakeLists.txt

@@ -120,6 +120,7 @@ INCLUDE_DIRECTORIES(
   sip_helpers
 
   ${CMAKE_BINARY_DIR}  # qgsconfig.h, qgsversion.h
+  ${CMAKE_BINARY_DIR}/src/core
 )
 
 IF(NOT ANDROID)

python/sip_helpers/CMakeLists.txt

@@ -17,7 +17,8 @@ INCLUDE_DIRECTORIES(SYSTEM
 )
 
 INCLUDE_DIRECTORIES(
-  ${CMAKE_CURRENT_BINARY_DIR}/../core
+  ${CMAKE_BINARY_DIR}/python/core
+  ${CMAKE_BINARY_DIR}/src/core
   ../../src/core
   ../../src/core/auth
   ../../src/core/pal

src/analysis/CMakeLists.txt

@@ -162,6 +162,7 @@ INCLUDE_DIRECTORIES(
   ${CMAKE_CURRENT_SOURCE_DIR}/../core/geometry
   ${CMAKE_CURRENT_SOURCE_DIR}/../core/raster
   ${CMAKE_CURRENT_SOURCE_DIR}/../core/symbology-ng
+  ${CMAKE_BINARY_DIR}/src/core
   interpolation
   network
 )

src/app/CMakeLists.txt

@@ -524,6 +524,7 @@ INCLUDE_DIRECTORIES(
   ${CMAKE_CURRENT_SOURCE_DIR} composer legend pluginmanager
   ${CMAKE_CURRENT_BINARY_DIR}
   ${CMAKE_CURRENT_BINARY_DIR}/../ui
+  ${CMAKE_BINARY_DIR}/src/core
 )
 INCLUDE_DIRECTORIES(SYSTEM
   ${QWT_INCLUDE_DIR}

src/app/dwg/libdxfrw/CMakeLists.txt

@@ -1,5 +1,6 @@
 INCLUDE_DIRECTORIES(
 	${CMAKE_SOURCE_DIR}/src/core
+        ${CMAKE_BINARY_DIR}/src/core
 	${Qt5Core_INCLUDE_DIRS}
 )
 

src/auth/basic/CMakeLists.txt

@@ -19,6 +19,7 @@ INCLUDE_DIRECTORIES (
   ../../core
   ../../core/auth
   ../../core/geometry
+  ${CMAKE_BINARY_DIR}/src/core
 )
 INCLUDE_DIRECTORIES (SYSTEM
   ${QCA_INCLUDE_DIR}

src/auth/identcert/CMakeLists.txt

@@ -19,6 +19,7 @@ INCLUDE_DIRECTORIES (
   ../../core
   ../../core/auth
   ../../core/geometry
+  ${CMAKE_BINARY_DIR}/src/core
 )
 INCLUDE_DIRECTORIES (SYSTEM
   ${QCA_INCLUDE_DIR}

src/auth/pkipaths/CMakeLists.txt

@@ -19,6 +19,7 @@ INCLUDE_DIRECTORIES (
   ../../core
   ../../core/auth
   ../../core/geometry
+  ${CMAKE_BINARY_DIR}/src/core
 )
 INCLUDE_DIRECTORIES (SYSTEM
   ${QCA_INCLUDE_DIR}

src/auth/pkipkcs12/CMakeLists.txt

@@ -19,6 +19,7 @@ INCLUDE_DIRECTORIES (
   ../../core
   ../../core/auth
   ../../core/geometry
+  ${CMAKE_BINARY_DIR}/src/core
 )
 INCLUDE_DIRECTORIES (SYSTEM
   ${QCA_INCLUDE_DIR}

src/browser/CMakeLists.txt

@@ -65,6 +65,7 @@ INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}
   ${CMAKE_CURRENT_SOURCE_DIR}/../gui/editorwidgets/core
   ${CMAKE_CURRENT_BINARY_DIR}/../ui
   ${CMAKE_CURRENT_BINARY_DIR}
+  ${CMAKE_BINARY_DIR}/src/core
 )
 INCLUDE_DIRECTORIES(SYSTEM
   ${GEOS_INCLUDE_DIR}

src/core/CMakeLists.txt

@@ -903,6 +903,7 @@ ENDIF (QT_MOBILITY_LOCATION_FOUND OR Qt5Positioning_FOUND)
 
 INCLUDE_DIRECTORIES(
   ${CMAKE_CURRENT_SOURCE_DIR}
+  ${CMAKE_CURRENT_BINARY_DIR}
   auth
   composer
   dxf
@@ -927,10 +928,6 @@ INCLUDE_DIRECTORIES(SYSTEM
   ${QCA_INCLUDE_DIR}
 )
 
-REMOVE_DEFINITIONS("-DCORE_EXPORT=${DLLIMPORT}")
-ADD_DEFINITIONS("\"-DCORE_EXPORT=${DLLEXPORT}\"")
-
-
 #for PAL classes
 IF (WIN32)
     ADD_DEFINITIONS("-D_HAVE_WINDOWS_H_")
@@ -946,6 +943,14 @@ ADD_DEFINITIONS(-DTEST_DATA_DIR="\\"${TEST_DATA_DIR}\\"")
 
 ADD_LIBRARY(qgis_core SHARED ${QGIS_CORE_SRCS} ${QGIS_CORE_MOC_SRCS} ${QGIS_CORE_HDRS} ${QGIS_CORE_MOC_HDRS})
 
+GENERATE_EXPORT_HEADER(
+  qgis_core
+  BASE_NAME CORE
+  EXPORT_FILE_NAME qgis_core.h
+)
+
+SET(QGIS_CORE_HDRS ${QGIS_CORE_HDRS} ${PROJECT_BINARY_DIR}/qgis_core.h)
+
 IF(ENABLE_MODELTEST)
   TARGET_LINK_LIBRARIES(qgis_core ${QT_QTTEST_LIBRARY})
 ENDIF(ENABLE_MODELTEST)

src/core/auth/qgsauthcertutils.h

@@ -23,6 +23,8 @@
 #include <QSslCertificate>
 #include <QSslError>
 
+#include "qgis_core.h"
+
 class QgsAuthConfigSslServer;
 
 #define SSL_ISSUER_INFO( var, prop ) var.issuerInfo( prop ).value(0)

src/core/auth/qgsauthcrypto.h

@@ -20,6 +20,8 @@
 #include <QFile>
 #include <QString>
 
+#include "qgis_core.h"
+
 /** \ingroup core
  * Funtions for hashing/checking master password and encrypt/decrypting data with password
  * \since 2.8

src/core/auth/qgsauthmethod.h

@@ -24,6 +24,8 @@
 #include <QStringList>
 #include <QUrl>
 
+#include "qgis_core.h"
+
 class QgsAuthMethodConfig;
 
 /** \ingroup core

src/core/auth/qgsauthmethodmetadata.h

@@ -19,6 +19,8 @@
 
 #include <QString>
 
+#include "qgis_core.h"
+
 /** \ingroup core
  * Holds data auth method key, description, and associated shared library file information.
 

src/core/auth/qgsauthmethodregistry.h

@@ -22,6 +22,8 @@
 #include <QMap>
 #include <QString>
 
+#include "qgis_core.h"
+
 class QgsAuthMethod;
 class QgsAuthMethodMetadata;
 

src/core/composer/qgsaddremoveitemcommand.h

@@ -19,6 +19,9 @@
 #define QGSADDREMOVEITEMCOMMAND_H
 
 #include <QUndoCommand>
+
+#include "qgis_core.h"
+
 class QgsComposerItem;
 class QgsComposition;
 

src/core/composer/qgsaddremovemultiframecommand.h

@@ -20,6 +20,8 @@
 
 #include <QUndoCommand>
 
+#include "qgis_core.h"
+
 class QgsComposerMultiFrame;
 class QgsComposition;
 

src/core/composer/qgscomposerattributetablemodelv2.h

@@ -21,6 +21,8 @@
 #include <QAbstractTableModel>
 #include <QSortFilterProxyModel>
 
+#include "qgis_core.h"
+
 class QgsComposerAttributeTableV2;
 class QgsComposerTableColumn;
 

src/core/composer/qgscomposereffect.h

@@ -21,6 +21,8 @@
 #include <QGraphicsEffect>
 #include <QPainter>
 
+#include "qgis_core.h"
+
 /** \ingroup core
  * \class QgsComposerEffect
  */

src/core/composer/qgscomposeritemcommand.h

@@ -21,6 +21,8 @@
 #include <QUndoCommand>
 #include <QDomDocument>
 
+#include "qgis_core.h"
+
 class QgsComposerItem;
 class QgsComposerMultiFrame;