Skip to content
Permalink
Browse files

Do not set min/max precision for int fields

Fixes #19050

QGIS saves integer field when I create a new real
field through field calculator (Update field works as intended)

backport required
  • Loading branch information
elpaso committed Jun 1, 2018
1 parent 9d3f8d4 commit 033071ae502ebafe80d85cc5c470c6abf501e925
Showing with 10 additions and 3 deletions.
  1. +10 −3 src/app/qgsfieldcalculator.cpp
@@ -493,9 +493,16 @@ void QgsFieldCalculator::setPrecisionMinMax()
int idx = mOutputFieldTypeComboBox->currentIndex();
int minPrecType = mOutputFieldTypeComboBox->itemData( idx, Qt::UserRole + FTC_MINPREC_IDX ).toInt();
int maxPrecType = mOutputFieldTypeComboBox->itemData( idx, Qt::UserRole + FTC_MAXPREC_IDX ).toInt();
mOutputFieldPrecisionSpinBox->setEnabled( minPrecType < maxPrecType );
mOutputFieldPrecisionSpinBox->setMinimum( minPrecType );
mOutputFieldPrecisionSpinBox->setMaximum( std::max( minPrecType, std::min( maxPrecType, mOutputFieldWidthSpinBox->value() ) ) );
bool precisionIsEnabled = minPrecType < maxPrecType;
mOutputFieldPrecisionSpinBox->setEnabled( precisionIsEnabled );
// Do not set min/max if it's disabled or we'll loose the default value,
// see https://issues.qgis.org/issues/19050 - QGIS saves integer field when
// I create a new real field through field calculator (Update field works as intended)
if ( precisionIsEnabled )
{
mOutputFieldPrecisionSpinBox->setMinimum( minPrecType );
mOutputFieldPrecisionSpinBox->setMaximum( std::max( minPrecType, std::min( maxPrecType, mOutputFieldWidthSpinBox->value() ) ) );
}
}

void QgsFieldCalculator::showHelp()

0 comments on commit 033071a

Please sign in to comment.
You can’t perform that action at this time.