Skip to content
Permalink
Browse files

[processing] fix wrong ParameterSelection definition

  • Loading branch information
alexbruy committed Dec 20, 2016
1 parent d129f8a commit 0340320cd083b4e84ce627b0daa074bdff20a403
Showing with 3 additions and 3 deletions.
  1. +3 −3 python/plugins/processing/algs/gdal/retile.py
@@ -80,7 +80,7 @@ def defineCharacteristics(self):
self.tr('Pixel size to be used for the output file (XSIZE YSIZE like 512 512)'),
None, False, True))
params.append(ParameterSelection(self.ALGORITHM,
self.tr('Resampling algorithm'), self.ALGO, 0, False, True))
self.tr('Resampling algorithm'), self.ALGO, 0, False, optional=True))
params.append(ParameterCrs(self.S_SRS,
self.tr('Override source CRS'), None, True))
params.append(ParameterNumber(self.PYRAMIDLEVELS,
@@ -91,10 +91,10 @@ def defineCharacteristics(self):
False, True))
params.append(ParameterSelection(self.RTYPE,
self.tr('Output raster type'),
self.TYPE, 5, False, True))
self.TYPE, 5, False, optional=True))
params.append(ParameterSelection(self.FORMAT,
self.tr('Output raster format'),
list(GdalUtils.getSupportedRasters().keys()), 0, False, True))
list(GdalUtils.getSupportedRasters().keys()), 0, False, optional=True))
params.append(ParameterBoolean(self.USEDIRFOREACHROW,
self.tr('Use a directory for each row'),
False, True))

9 comments on commit 0340320

@m-kuhn

This comment has been minimized.

Copy link
Member

@m-kuhn m-kuhn replied Dec 20, 2016

Wasn't the test for this commit failing before?

@alexbruy

This comment has been minimized.

Copy link
Contributor Author

@alexbruy alexbruy replied Dec 20, 2016

Yes, it failed before on Travis, but passed locally. Fixed after rerunning build

@m-kuhn

This comment has been minimized.

Copy link
Member

@m-kuhn m-kuhn replied Dec 20, 2016

It failed in the followup commit (which I only made to debug this failure)

https://travis-ci.org/qgis/QGIS/builds/185500692#L840-L843

Any idea?

@alexbruy

This comment has been minimized.

Copy link
Contributor Author

@alexbruy alexbruy replied Dec 20, 2016

I have no ideas, this commit even not related to failed test. Trying to debug it right now

@m-kuhn

This comment has been minimized.

Copy link
Member

@m-kuhn m-kuhn replied Dec 21, 2016

Did you find anything?
All builds are currently failing.

@ghtmtt

This comment has been minimized.

Copy link
Contributor

@ghtmtt ghtmtt replied Dec 21, 2016

I don't know if could help, but locally the test runs without problems:

The following tests passed:
	ProcessingParametersTest

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   1.83 sec
@m-kuhn

This comment has been minimized.

Copy link
Member

@m-kuhn m-kuhn replied Dec 21, 2016

It only fails 1 out of 5 times.

Probably since 97780b6

@ghtmtt

This comment has been minimized.

Copy link
Contributor

@ghtmtt ghtmtt replied Dec 21, 2016

OK I see.. Can I help in some way?

@m-kuhn

This comment has been minimized.

Copy link
Member

@m-kuhn m-kuhn replied Dec 21, 2016

Someone needs to fix ParameterFixedTable.fromScriptCode which was probably copied from ParameterPoint and not completely adjusted.

Please sign in to comment.
You can’t perform that action at this time.