[processing] Remove all remaining algorithm copies

Algorithms are no longer copied - just a single const instance
of each algorithm is used

Author: nyalldawson

python/core/processing/qgsprocessingalgorithm.sip

@@ -110,8 +110,6 @@ class QgsProcessingAlgorithm
  :rtype: QgsProcessingProvider
 %End
 
-    void setProvider( QgsProcessingProvider *provider );
-
     QgsProcessingParameterDefinitions parameterDefinitions() const;
 %Docstring
  Returns an ordered list of parameter definitions utilized by the algorithm.

python/plugins/processing/algs/gdal/GdalAlgorithm.py

@@ -92,12 +92,11 @@ def shortHelp(self):
                 '''.format(self.commandName(), url))
 
     def commandName(self):
-        alg = self.getCopy()
-        for output in alg.outputs:
+        for output in self.outputs:
             output.setValue("dummy")
-        for param in alg.parameters:
+        for param in self.parameters:
             param.setValue("1")
-        name = alg.getConsoleCommands()[0]
+        name = self.getConsoleCommands()[0]
         if name.endswith(".py"):
             name = name[:-3]
         return name

python/plugins/processing/algs/grass7/Grass7Algorithm.py

@@ -97,9 +97,6 @@ def __init__(self, descriptionfile):
         except ImportError:
             self.module = None
 
-    def getCopy(self):
-        return self
-
     def name(self):
         return self._name
 

python/plugins/processing/algs/saga/SagaAlgorithm.py

@@ -78,9 +78,6 @@ def __init__(self, descriptionfile):
         self._display_name = ''
         self._group = ''
 
-    def getCopy(self):
-        return self
-
     def icon(self):
         if self._icon is None:
             self._icon = QIcon(os.path.join(pluginPath, 'images', 'saga.png'))

python/plugins/processing/core/GeoAlgorithm.py

@@ -74,15 +74,6 @@ def __init__(self):
 
         self.defineCharacteristics()
 
-    def getCopy(self):
-        """Returns a new instance of this algorithm, ready to be used
-        for being executed.
-        """
-        newone = self
-        newone.parameters = copy.deepcopy(self.parameters)
-        newone.outputs = copy.deepcopy(self.outputs)
-        return newone
-
     # methods to overwrite when creating a custom geoalgorithm
 
     def _formatHelp(self, text):

python/plugins/processing/core/Processing.py

@@ -130,11 +130,6 @@ def runAlgorithm(algOrName, onFinish, *args, **kwargs):
             QgsMessageLog.logMessage(Processing.tr('Error: Algorithm {0} not found\n').format(algOrName),
                                      Processing.tr("Processing"))
             return
-        # hack - remove when getCopy is removed
-        provider = alg.provider()
-        alg = alg.getCopy()
-        #hack pt2
-        alg.setProvider(provider)
 
         if len(args) == 1 and isinstance(args[0], dict):
             # Set params by name and try to run the alg even if not all parameter values are provided,

python/plugins/processing/gui/BatchAlgorithmDialog.py

@@ -72,9 +72,7 @@ def accept(self):
         self.canceled = False
 
         for row in range(self.mainWidget.tblParameters.rowCount()):
-            alg = self.alg.getCopy()
-            # hack - remove when getCopy is removed
-            alg.setProvider(self.alg.provider())
+            alg = self.alg
             col = 0
             for param in alg.parameters:
                 if param.hidden:

python/plugins/processing/gui/BatchPanel.py

@@ -182,7 +182,7 @@ def save(self):
             algParams = {}
             algOutputs = {}
             col = 0
-            alg = self.alg.getCopy()
+            alg = self.alg
             for param in alg.parameters:
                 if param.hidden:
                     continue

python/plugins/processing/gui/EditRenderingStylesDialog.py

@@ -48,7 +48,7 @@ def __init__(self, alg):
         super(EditRenderingStylesDialog, self).__init__(None)
         self.setupUi(self)
 
-        self.alg = alg.getCopy()
+        self.alg = alg
 
         self.tblStyles.horizontalHeader().setSectionResizeMode(QHeaderView.Stretch)
         self.setWindowTitle(self.alg.displayName())

python/plugins/processing/gui/ProcessingToolbox.py

@@ -246,11 +246,6 @@ def executeAlgorithmAsBatchProcess(self):
         item = self.algorithmTree.currentItem()
         if isinstance(item, TreeAlgorithmItem):
             alg = QgsApplication.processingRegistry().algorithmById(item.alg.id())
-            #hack - remove when getCopy is removed
-            provider = alg.provider()
-            alg = alg.getCopy()
-            #hack pt 2
-            alg.setProvider(provider)
             dlg = BatchAlgorithmDialog(alg)
             dlg.show()
             dlg.exec_()
@@ -270,11 +265,6 @@ def executeAlgorithm(self):
                 dlg.exec_()
                 return
 
-            # temporary hack - TODO remove this getCopy when parameters are moved from algorithm
-            provider = alg.provider()
-            alg = alg.getCopy()
-            alg.setProvider(provider)
-
             if (alg.countVisibleParameters() + alg.getVisibleOutputsCount()) > 0:
                 dlg = alg.getCustomParametersDialog()
                 if not dlg: