Skip to content

Commit 0461cbd

Browse files
committed
use aliases instead of field names in attribute table column filter list
1 parent f1fe985 commit 0461cbd

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/app/qgsattributetabledialog.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ void QgsAttributeTableDialog::columnBoxInit()
327327
mFilterButton->addAction( mActionFilterColumnsMenu );
328328
mFilterButton->addAction( mActionAdvancedFilter );
329329

330-
QList<QgsField> fields = mLayer->fields().toList();
330+
const QList<QgsField> fields = mLayer->fields().toList();
331331

332332
Q_FOREACH ( const QgsField& field, fields )
333333
{
@@ -338,10 +338,11 @@ void QgsAttributeTableDialog::columnBoxInit()
338338
if ( mLayer->editorWidgetV2( idx ) != "Hidden" )
339339
{
340340
QIcon icon = QgsApplication::getThemeIcon( "/mActionNewAttribute.png" );
341-
QString text = field.name();
341+
QString alias = mLayer->attributeDisplayName( idx );
342342

343343
// Generate action for the filter popup button
344-
QAction* filterAction = new QAction( icon, text, mFilterButton );
344+
QAction* filterAction = new QAction( icon, alias, mFilterButton );
345+
filterAction->setData( field.name() );
345346
mFilterActionMapper->setMapping( filterAction, filterAction );
346347
connect( filterAction, SIGNAL( triggered() ), mFilterActionMapper, SLOT( map() ) );
347348
mFilterColumnsMenu->addAction( filterAction );
@@ -453,7 +454,7 @@ void QgsAttributeTableDialog::filterColumnChanged( QObject* filterAction )
453454
mCurrentSearchWidgetWrapper->widget()->setVisible( false );
454455
delete mCurrentSearchWidgetWrapper;
455456
}
456-
QString fieldName = mFilterButton->defaultAction()->text();
457+
QString fieldName = mFilterButton->defaultAction()->data().toString();
457458
// get the search widget
458459
int fldIdx = mLayer->fieldNameIndex( fieldName );
459460
if ( fldIdx < 0 )

0 commit comments

Comments
 (0)