Merge pull request #8336 from m-kuhn/doNotReportEnvelopeAsGap

m-kuhn · web-flow · commit 0633ee04a30b · 2018-10-26T13:00:21.000+02:00
Do not report envelope as gap
diff --git a/src/analysis/vector/geometry_checker/qgsgeometrygapcheck.cpp b/src/analysis/vector/geometry_checker/qgsgeometrygapcheck.cpp
@@ -98,7 +98,8 @@ void QgsGeometryGapCheck::collectErrors( const QMap<QString, QgsFeaturePool *> &
   {
     std::unique_ptr<QgsAbstractGeometry> gapGeom( QgsGeometryCheckerUtils::getGeomPart( diffGeom.get(), iPart )->clone() );
     // Skip the gap between features and boundingbox
-    if ( gapGeom->boundingBox() == envelope->boundingBox() )
+    const double spacing = context()->tolerance;
+    if ( gapGeom->boundingBox().snappedToGrid( spacing ) == envelope->boundingBox().snappedToGrid( spacing ) )
     {
       continue;
     }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,8 @@ void QgsGeometryGapCheck::collectErrors( const QMap<QString, QgsFeaturePool *> &`
`98`	`98`	`{`
`99`	`99`	`std::unique_ptr<QgsAbstractGeometry> gapGeom( QgsGeometryCheckerUtils::getGeomPart( diffGeom.get(), iPart )->clone() );`
`100`	`100`	`// Skip the gap between features and boundingbox`
`101`		`- if ( gapGeom->boundingBox() == envelope->boundingBox() )`
	`101`	`+ const double spacing = context()->tolerance;`
	`102`	`+ if ( gapGeom->boundingBox().snappedToGrid( spacing ) == envelope->boundingBox().snappedToGrid( spacing ) )`
`102`	`103`	`{`
`103`	`104`	`continue;`
`104`	`105`	`}`