Skip to content

/ QGIS

Permalink
Browse files

[Geometry checker] Some initial tests

  • Loading branch information
@manisandro
manisandro committed Sep 27, 2017
1 parent 54019e1 commit 07dc429573bf95b829007bf2ae8e9167c3169f84
1 tests/src/CMakeLists.txt
View file
@@ -45,4 +45,5 @@ IF (ENABLE_TESTS)
IF (WITH_BINDINGS)
ADD_SUBDIRECTORY(python)
ENDIF (WITH_BINDINGS)
ADD_SUBDIRECTORY(geometry_checker)
ENDIF (ENABLE_TESTS)
59 tests/src/geometry_checker/CMakeLists.txt
View file
@@ -0,0 +1,59 @@
# Standard includes and utils to compile into all tests.

#####################################################
# Don't forget to include output directory, otherwise
# the UI file won't be wrapped!
INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_CURRENT_BINARY_DIR}
${CMAKE_SOURCE_DIR}/src/core
${CMAKE_SOURCE_DIR}/src/core/expression
${CMAKE_SOURCE_DIR}/src/core/geometry
${CMAKE_SOURCE_DIR}/src/core/metadata
${CMAKE_SOURCE_DIR}/src/analysis/
${CMAKE_SOURCE_DIR}/src/analysis/vector/geometry_checker
${CMAKE_SOURCE_DIR}/src/test
${CMAKE_SOURCE_DIR}/src/plugins
${CMAKE_BINARY_DIR}/src/core
${CMAKE_BINARY_DIR}/src/analysis
)
INCLUDE_DIRECTORIES(SYSTEM
${QT_INCLUDE_DIR}
${GDAL_INCLUDE_DIR}
${PROJ_INCLUDE_DIR}
${GEOS_INCLUDE_DIR}
${QCA_INCLUDE_DIR}
${QTKEYCHAIN_INCLUDE_DIR}
${POSTGRES_INCLUDE_DIR}
)

#note for tests we should not include the moc of our
#qtests in the executable file list as the moc is
#directly included in the sources
#and should not be compiled twice. Trying to include
#them in will cause an error at build time

#No relinking and full RPATH for the install tree
#See: http://www.cmake.org/Wiki/CMake_RPATH_handling#No_relinking_and_full_RPATH_for_the_install_tree

MACRO (ADD_QGIS_TEST testname testsrc)
SET(qgis_${testname}_SRCS ${testsrc} ${util_SRCS})
ADD_CUSTOM_TARGET(qgis_${testname}moc ALL DEPENDS ${qgis_${testname}_MOC_SRCS})
ADD_EXECUTABLE(qgis_${testname} ${qgis_${testname}_SRCS})
SET_TARGET_PROPERTIES(qgis_${testname} PROPERTIES AUTOMOC TRUE)
TARGET_LINK_LIBRARIES(qgis_${testname}
${QT_QTXML_LIBRARY}
${QT_QTCORE_LIBRARY}
${QT_QTSVG_LIBRARY}
${QT_QTTEST_LIBRARY}
${PROJ_LIBRARY}
${GEOS_LIBRARY}
${GDAL_LIBRARY}
qgis_core
qgis_analysis)
ADD_TEST(qgis_${testname} ${CMAKE_CURRENT_BINARY_DIR}/../../../output/bin/qgis_${testname} -maxwarnings 10000)
ENDMACRO (ADD_QGIS_TEST)

#############################################################
# Tests:

ADD_QGIS_TEST( qgsgeometrycheckstest testqgsgeometrychecks.cpp )
310 tests/src/geometry_checker/testqgsgeometrychecks.cpp
View file
@@ -0,0 +1,310 @@
/***************************************************************************
testqgsgeometrychecks.cpp
--------------------------------------
Date : September 2017
Copyright : (C) 2017 Sandro Mani
Email : manisandro at gmail dot com
***************************************************************************
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
* *
***************************************************************************/

#include "qgstest.h"
#include "qgscrscache.h"
#include "qgsfeature.h"
#include "qgsfeaturepool.h"
#include "qgsvectorlayer.h"

#include "qgsgeometryanglecheck.h"
#include "qgsgeometryareacheck.h"
#include "qgsgeometrycontainedcheck.h"
#include "qgsgeometrydanglecheck.h"
#include "qgsgeometrydegeneratepolygoncheck.h"
#include "qgsgeometryduplicatecheck.h"
#include "qgsgeometryduplicatenodescheck.h"

#include "qgsgeometrygapcheck.h"
#include "qgsgeometryholecheck.h"
#include "qgsgeometrylineintersectioncheck.h"
#include "qgsgeometrylinelayerintersectioncheck.h"
#include "qgsgeometrymultipartcheck.h"
#include "qgsgeometryoverlapcheck.h"
#include "qgsgeometrypointcoveredbylinecheck.h"
#include "qgsgeometrypointinpolygoncheck.h"
#include "qgsgeometrysegmentlengthcheck.h"
#include "qgsgeometryselfcontactcheck.h"
#include "qgsgeometryselfintersectioncheck.h"
#include "qgsgeometrysliverpolygoncheck.h"
#include "qgsgeometrytypecheck.h"


class TestQgsGeometryChecks: public QObject
{
Q_OBJECT
private:
double layerToMapUnits( const QgsMapLayer *layer, const QString &mapCrs ) const;
QgsFeaturePool *createFeaturePool( QgsVectorLayer *layer, const QString &mapCrs, bool selectedOnly = false ) const;
QgsGeometryCheckerContext *createTestContext( QMap<QString, QString> &layers, const QString &mapCrs = "EPSG:4326", double prec = 8 ) const;
void cleanupTestContext( QgsGeometryCheckerContext *ctx ) const;
void listErrors( const QList<QgsGeometryCheckError *> &checkErrors, const QStringList &messages ) const;
int searchCheckError( const QList<QgsGeometryCheckError *> &checkErrors, const QString &layerId, const QgsFeatureId &featureId = -1, const QgsPointXY &pos = QgsPointXY(), const QgsVertexId &vid = QgsVertexId(), const QVariant &value = QVariant(), double tol = 1E-4 ) const;

QMap<QString, QString> mLayers;
QgsGeometryCheckerContext *mContext;

private slots:
// will be called before the first testfunction is executed.
void initTestCase();
// will be called after the last testfunction is executed.
void cleanupTestCase();

void testAngleCheck();
void testAreaCheck();
void testContainedCheck();
void testDangleCheck();
void testDegeneratePolygonCheck();
void testDuplicateCheck();
void testDuplicateNodesCheck();
};

void TestQgsGeometryChecks::initTestCase()
{
QgsApplication::initQgis();

mLayers.insert( "point_layer.shp", "" );
mLayers.insert( "line_layer.shp", "" );
mLayers.insert( "polygon_layer.shp", "" );
mContext = createTestContext( mLayers );
}

void TestQgsGeometryChecks::cleanupTestCase()
{
cleanupTestContext( mContext );
QgsApplication::exitQgis();
}

///////////////////////////////////////////////////////////////////////////////

void TestQgsGeometryChecks::testAngleCheck()
{
QList<QgsGeometryCheckError *> checkErrors;
QStringList messages;

QgsGeometryAngleCheck( mContext, 15 ).collectErrors( checkErrors, messages );
listErrors( checkErrors, messages );

QCOMPARE( checkErrors.size(), 7 );
QVERIFY( searchCheckError( checkErrors, mLayers["point_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 0, QgsPointXY( -0.2225, 0.5526 ), QgsVertexId( 0, 0, 3 ), 10.5865 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 0, QgsPointXY( -0.94996, 0.99967 ), QgsVertexId( 1, 0, 1 ), 8.3161 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 2, QgsPointXY( -0.4547, -0.3059 ), QgsVertexId( 0, 0, 1 ), 5.4165 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 2, QgsPointXY( -0.7594, -0.1971 ), QgsVertexId( 0, 0, 2 ), 12.5288 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 0, QgsPointXY( 0.2402, 1.0786 ), QgsVertexId( 0, 0, 1 ), 13.5140 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 1, QgsPointXY( 0.6960, 0.5908 ), QgsVertexId( 0, 0, 0 ), 7.0556 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 1, QgsPointXY( 0.98690, 0.55699 ), QgsVertexId( 1, 0, 5 ), 7.7351 ) == 1 );
}

void TestQgsGeometryChecks::testAreaCheck()
{
QList<QgsGeometryCheckError *> checkErrors;
QStringList messages;

QgsGeometryAreaCheck( mContext, 0.04 ).collectErrors( checkErrors, messages );
listErrors( checkErrors, messages );

QCOMPARE( checkErrors.size(), 3 );
QVERIFY( searchCheckError( checkErrors, mLayers["point_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 1, QgsPointXY( 1.0068, 0.3635 ), QgsVertexId(), 0.0105 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 2, QgsPointXY( 0.9739, 1.0983 ), QgsVertexId(), 0.0141 ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 6, QgsPointXY( 0.9968, 1.7584 ), QgsVertexId(), 0 ) == 1 );
}

void TestQgsGeometryChecks::testContainedCheck()
{
QList<QgsGeometryCheckError *> checkErrors;
QStringList messages;

QgsGeometryContainedCheck( mContext ).collectErrors( checkErrors, messages );
listErrors( checkErrors, messages );

QCOMPARE( checkErrors.size(), 3 );
QVERIFY( searchCheckError( checkErrors, mLayers["point_layer.shp"], 5, QgsPointXY(), QgsVertexId(), QVariant( "polygon_layer.shp:0" ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 3, QgsPointXY(), QgsVertexId(), QVariant( "polygon_layer.shp:0" ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 3, QgsPointXY(), QgsVertexId(), QVariant( "polygon_layer.shp:0" ) ) == 1 );
QVERIFY( messages.contains( "Contained check failed for (polygon_layer.shp:1): the geometry is invalid" ) );
}

void TestQgsGeometryChecks::testDangleCheck()
{
QList<QgsGeometryCheckError *> checkErrors;
QStringList messages;

QgsGeometryDangleCheck( mContext ).collectErrors( checkErrors, messages );
listErrors( checkErrors, messages );

QCOMPARE( checkErrors.size(), 4 );
QVERIFY( searchCheckError( checkErrors, mLayers["point_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 0, QgsPointXY( -0.7558, 0.7648 ), QgsVertexId( 1, 0, 0 ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 2, QgsPointXY( -0.7787, -0.2237 ), QgsVertexId( 0, 0, 0 ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 3, QgsPointXY( -0.2326, 0.9537 ), QgsVertexId( 0, 0, 0 ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 3, QgsPointXY( 0.07913, 0.8012 ), QgsVertexId( 0, 0, 2 ) ) == 1 );
}

void TestQgsGeometryChecks::testDegeneratePolygonCheck()
{
QList<QgsGeometryCheckError *> checkErrors;
QStringList messages;

QgsGeometryDegeneratePolygonCheck( mContext ).collectErrors( checkErrors, messages );
listErrors( checkErrors, messages );

QCOMPARE( checkErrors.size(), 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["point_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 6 ) == 1 );
}

void TestQgsGeometryChecks::testDuplicateCheck()
{
QList<QgsGeometryCheckError *> checkErrors;
QStringList messages;

QgsGeometryDuplicateCheck( mContext ).collectErrors( checkErrors, messages );
listErrors( checkErrors, messages );

QCOMPARE( checkErrors.size(), 3 );
QVERIFY(
searchCheckError( checkErrors, mLayers["point_layer.shp"], 6, QgsPoint(), QgsVertexId(), QVariant( "point_layer.shp:2" ) ) == 1
|| searchCheckError( checkErrors, mLayers["point_layer.shp"], 2, QgsPoint(), QgsVertexId(), QVariant( "point_layer.shp:6" ) ) == 1 );
QVERIFY(
searchCheckError( checkErrors, mLayers["line_layer.shp"], 4, QgsPoint(), QgsVertexId(), QVariant( "line_layer.shp:7" ) ) == 1
|| searchCheckError( checkErrors, mLayers["line_layer.shp"], 7, QgsPoint(), QgsVertexId(), QVariant( "line_layer.shp:4" ) ) == 1 );
QVERIFY(
searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 8, QgsPoint(), QgsVertexId(), QVariant( "polygon_layer.shp:7" ) ) == 1
|| searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 7, QgsPoint(), QgsVertexId(), QVariant( "polygon_layer.shp:8" ) ) == 1 );
}

void TestQgsGeometryChecks::testDuplicateNodesCheck()
{
QList<QgsGeometryCheckError *> checkErrors;
QStringList messages;

QgsGeometryDuplicateNodesCheck( mContext ).collectErrors( checkErrors, messages );
listErrors( checkErrors, messages );

QCOMPARE( checkErrors.size(), 4 );
QVERIFY( searchCheckError( checkErrors, mLayers["point_layer.shp"] ) == 0 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 0, QgsPointXY( -0.6360, 0.6203 ), QgsVertexId( 0, 0, 5 ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 6, QgsPointXY( 0.2473, 2.0821 ), QgsVertexId( 0, 0, 1 ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["line_layer.shp"], 6, QgsPointXY( 0.5158, 2.0930 ), QgsVertexId( 0, 0, 3 ) ) == 1 );
QVERIFY( searchCheckError( checkErrors, mLayers["polygon_layer.shp"], 4, QgsPointXY( 1.6319, 0.5642 ), QgsVertexId( 0, 0, 1 ) ) == 1 );
}

///////////////////////////////////////////////////////////////////////////////

double TestQgsGeometryChecks::layerToMapUnits( const QgsMapLayer *layer, const QString &mapCrs ) const
{
QgsCoordinateTransform crst = QgsCoordinateTransformCache::instance()->transform( layer->crs().authid(), mapCrs );
QgsRectangle extent = layer->extent();
QgsPointXY l1( extent.xMinimum(), extent.yMinimum() );
QgsPointXY l2( extent.xMaximum(), extent.yMaximum() );
double distLayerUnits = std::sqrt( l1.sqrDist( l2 ) );
QgsPointXY m1 = crst.transform( l1 );
QgsPointXY m2 = crst.transform( l2 );
double distMapUnits = std::sqrt( m1.sqrDist( m2 ) );
return distMapUnits / distLayerUnits;
}

QgsFeaturePool *TestQgsGeometryChecks::createFeaturePool( QgsVectorLayer *layer, const QString &mapCrs, bool selectedOnly ) const
{
double layerToMapUntis = layerToMapUnits( layer, mapCrs );
QgsCoordinateTransform layerToMapTransform = QgsCoordinateTransformCache::instance()->transform( layer->crs().authid(), mapCrs );
return new QgsFeaturePool( layer, layerToMapUntis, layerToMapTransform, selectedOnly );
}

QgsGeometryCheckerContext *TestQgsGeometryChecks::createTestContext( QMap<QString, QString> &layers, const QString &mapCrs, double prec ) const
{
QDir testDataDir( QDir( TEST_DATA_DIR ).absoluteFilePath( "geometry_checker" ) );

QMap<QString, QgsFeaturePool *> featurePools;
for ( const QString &layerFile : layers.keys() )
{
QgsVectorLayer *layer = new QgsVectorLayer( testDataDir.absoluteFilePath( layerFile ), layerFile );
Q_ASSERT( layer && layer->isValid() );
layers[layerFile] = layer->id();
featurePools.insert( layer->id(), createFeaturePool( layer, mapCrs ) );
}
return new QgsGeometryCheckerContext( prec, mapCrs, featurePools );
}

void TestQgsGeometryChecks::cleanupTestContext( QgsGeometryCheckerContext *ctx ) const
{
for ( const QgsFeaturePool *pool : ctx->featurePools )
{
delete pool->getLayer();
}
qDeleteAll( ctx->featurePools );
delete ctx;
}

void TestQgsGeometryChecks::listErrors( const QList<QgsGeometryCheckError *> &checkErrors, const QStringList &messages ) const
{
QTextStream( stdout ) << " - Check result:" << endl;
for ( const QgsGeometryCheckError *error : checkErrors )
{
QTextStream( stdout ) << " * " << error->layerId() << ":" << error->featureId() << " @[" << error->vidx().part << ", " << error->vidx().ring << ", " << error->vidx().vertex << "](" << error->location().x() << ", " << error->location().y() << ") = " << error->value().toString() << endl;
}
if ( !messages.isEmpty() )
{
QTextStream( stdout ) << " - Check messages:" << endl << " * " << messages.join( "\n * " ) << endl;
}
}

int TestQgsGeometryChecks::searchCheckError( const QList<QgsGeometryCheckError *> &checkErrors, const QString &layerId, const QgsFeatureId &featureId, const QgsPointXY &pos, const QgsVertexId &vid, const QVariant &value, double tol ) const
{
int matching = 0;
for ( const QgsGeometryCheckError *error : checkErrors )
{
if ( error->layerId() != layerId )
{
continue;
}
if ( featureId != -1 && error->featureId() != featureId )
{
continue;
}
if ( pos != QgsPointXY() && ( !qgsDoubleNear( error->location().x(), pos.x(), tol ) || !qgsDoubleNear( error->location().y(), pos.y(), tol ) ) )
{
continue;
}
if ( vid.isValid() && vid != error->vidx() )
{
continue;
}
if ( !value.isNull() )
{
if ( value.type() == QVariant::Double )
{
if ( !qgsDoubleNear( value.toDouble(), error->value().toDouble(), tol ) )
{
continue;
}
}
else if ( value != error->value() )
{
continue;
}
}
++matching;
}
return matching;
}

QGSTEST_MAIN( TestQgsGeometryChecks )
#include "testqgsgeometrychecks.moc"
1 tests/testdata/geometry_checker/line_layer.cpg
View file
@@ -0,0 +1 @@
UTF-8
BIN +153 Bytes tests/testdata/geometry_checker/line_layer.dbf
View file
Binary file not shown.
1 tests/testdata/geometry_checker/line_layer.prj
View file
@@ -0,0 +1 @@
GEOGCS["GCS_WGS_1984",DATUM["D_WGS_1984",SPHEROID["WGS_1984",6378137,298.257223563]],PRIMEM["Greenwich",0],UNIT["Degree",0.017453292519943295]]
1 tests/testdata/geometry_checker/line_layer.qpj
View file
@@ -0,0 +1 @@
GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AUTHORITY["EPSG","4326"]]
BIN +1.18 KB tests/testdata/geometry_checker/line_layer.shp
View file
Binary file not shown.
BIN +164 Bytes tests/testdata/geometry_checker/line_layer.shx
View file
Binary file not shown.
1 tests/testdata/geometry_checker/point_layer.cpg
View file
@@ -0,0 +1 @@
UTF-8
BIN +142 Bytes tests/testdata/geometry_checker/point_layer.dbf
View file
Binary file not shown.
1 tests/testdata/geometry_checker/point_layer.prj
View file
@@ -0,0 +1 @@
GEOGCS["GCS_WGS_1984",DATUM["D_WGS_1984",SPHEROID["WGS_1984",6378137,298.257223563]],PRIMEM["Greenwich",0],UNIT["Degree",0.017453292519943295]]
1 tests/testdata/geometry_checker/point_layer.qpj
View file
@@ -0,0 +1 @@
GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS 84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AUTHORITY["EPSG","4326"]]
BIN +296 Bytes tests/testdata/geometry_checker/point_layer.shp
View file
Binary file not shown.
BIN +156 Bytes tests/testdata/geometry_checker/point_layer.shx
View file
Binary file not shown.
1 tests/testdata/geometry_checker/polygon_layer.cpg
View file
@@ -0,0 +1 @@
UTF-8
BIN +164 Bytes tests/testdata/geometry_checker/polygon_layer.dbf
View file
Binary file not shown.
1 tests/testdata/geometry_checker/polygon_layer.prj
View file
@@ -0,0 +1 @@
GEOGCS["GCS_WGS_1984",DATUM["D_WGS_1984",SPHEROID["WGS_1984",6378137,298.257223563]],PRIMEM["Greenwich",0],UNIT["Degree",0.017453292519943295]]

0 comments on commit 07dc429

Please sign in to comment.
You can’t perform that action at this time.