Replace reimplemented default methods by = default

Using clang-tidy modernize-use-equals-default

Author: nyalldawson

python/core/qgsdiagramrenderer.sip

@@ -11,7 +11,6 @@
 
 
 
-
 class QgsDiagramLayerSettings
 {
 %Docstring

python/core/qgspropertytransformer.sip

@@ -339,11 +339,6 @@ class QgsGenericNumericTransformer : QgsPropertyTransformer
  \param exponent optional exponential for non-linear scaling
 %End
 
-    QgsGenericNumericTransformer( const QgsGenericNumericTransformer &other );
-%Docstring
- Copy constructor.
-%End
-
     virtual Type transformerType() const;
     virtual QgsGenericNumericTransformer *clone() const /Factory/;
     virtual QVariant toVariant() const;
@@ -475,11 +470,6 @@ class QgsSizeScaleTransformer : QgsPropertyTransformer
  \param exponent exponent for Exponential scaling method
 %End
 
-    QgsSizeScaleTransformer( const QgsSizeScaleTransformer &other );
-%Docstring
- Copy constructor.
-%End
-
     virtual Type transformerType() const;
     virtual QgsSizeScaleTransformer *clone() const /Factory/;
     virtual QVariant toVariant() const;

python/core/symbology/qgscategorizedsymbolrenderer.sip

@@ -78,7 +78,6 @@ class QgsCategorizedSymbolRenderer : QgsFeatureRenderer
   public:
 
     QgsCategorizedSymbolRenderer( const QString &attrName = QString(), const QgsCategoryList &categories = QgsCategoryList() );
-    ~QgsCategorizedSymbolRenderer();
 
     virtual QgsSymbol *symbolForFeature( QgsFeature &feature, QgsRenderContext &context );
     virtual QgsSymbol *originalSymbolForFeature( QgsFeature &feature, QgsRenderContext &context );

python/core/symbology/qgssinglesymbolrenderer.sip

@@ -17,7 +17,6 @@ class QgsSingleSymbolRenderer : QgsFeatureRenderer
   public:
 
     QgsSingleSymbolRenderer( QgsSymbol *symbol /Transfer/ );
-    ~QgsSingleSymbolRenderer();
 
     virtual QgsSymbol *symbolForFeature( QgsFeature &feature, QgsRenderContext &context );
     virtual QgsSymbol *originalSymbolForFeature( QgsFeature &feature, QgsRenderContext &context );

python/gui/attributetable/qgsfeaturelistmodel.sip

@@ -34,7 +34,6 @@ class QgsFeatureListModel : QAbstractProxyModel, QgsFeatureModel
 
   public:
     explicit QgsFeatureListModel( QgsAttributeTableFilterModel *sourceModel, QObject *parent /TransferThis/ = 0 );
-    virtual ~QgsFeatureListModel();
 
     virtual void setSourceModel( QgsAttributeTableFilterModel *sourceModel );
     QgsVectorLayerCache *layerCache();

python/gui/attributetable/qgsfieldconditionalformatwidget.sip

@@ -28,8 +28,6 @@ class QgsFieldConditionalFormatWidget : QWidget
  \param parent parent widget
 %End
 
-    ~QgsFieldConditionalFormatWidget();
-
     void viewRules();
 %Docstring
  Switches the widget to the rules page.

python/gui/symbology/qgssvgselectorwidget.sip

@@ -75,7 +75,6 @@ class QgsSvgSelectorWidget : QWidget
 %End
   public:
     QgsSvgSelectorWidget( QWidget *parent /TransferThis/ = 0 );
-    ~QgsSvgSelectorWidget();
 
     QString currentSvgPath() const;
 %Docstring

src/analysis/network/qgsgraph.cpp

@@ -20,10 +20,6 @@
 
 #include "qgsgraph.h"
 
-QgsGraph::QgsGraph()
-{
-}
-
 int QgsGraph::addVertex( const QgsPointXY &pt )
 {
   mGraphVertexes.append( QgsGraphVertex( pt ) );

src/analysis/network/qgsgraph.h

@@ -131,7 +131,7 @@ class ANALYSIS_EXPORT QgsGraphVertex
 class ANALYSIS_EXPORT QgsGraph
 {
   public:
-    QgsGraph();
+    QgsGraph() = default;
 
     // Graph constructing methods
 

src/app/composer/qgsatlascompositionwidget.cpp

@@ -59,10 +59,6 @@ QgsAtlasCompositionWidget::QgsAtlasCompositionWidget( QWidget *parent, QgsCompos
   updateGuiElements();
 }
 
-QgsAtlasCompositionWidget::~QgsAtlasCompositionWidget()
-{
-}
-
 void QgsAtlasCompositionWidget::on_mUseAtlasCheckBox_stateChanged( int state )
 {
   QgsAtlasComposition *atlasMap = &mComposition->atlasComposition();

src/app/composer/qgsatlascompositionwidget.h

@@ -31,7 +31,6 @@ class QgsAtlasCompositionWidget:
     Q_OBJECT
   public:
     QgsAtlasCompositionWidget( QWidget *parent, QgsComposition *c );
-    ~QgsAtlasCompositionWidget();
 
   public slots:
     void on_mUseAtlasCheckBox_stateChanged( int state );

src/app/composer/qgscomposerarrowwidget.cpp

@@ -61,11 +61,6 @@ QgsComposerArrowWidget::QgsComposerArrowWidget( QgsComposerArrow *arrow ): QgsCo
   }
 }
 
-QgsComposerArrowWidget::~QgsComposerArrowWidget()
-{
-
-}
-
 void QgsComposerArrowWidget::on_mStrokeWidthSpinBox_valueChanged( double d )
 {
   if ( !mArrow )

src/app/composer/qgscomposerarrowwidget.h

@@ -28,7 +28,6 @@ class QgsComposerArrowWidget: public QgsComposerItemBaseWidget, private Ui::QgsC
     Q_OBJECT
   public:
     explicit QgsComposerArrowWidget( QgsComposerArrow *arrow );
-    ~QgsComposerArrowWidget();
 
   private:
     QgsComposerArrow *mArrow = nullptr;

src/app/composer/qgscomposerattributetablewidget.cpp

@@ -114,10 +114,6 @@ QgsComposerAttributeTableWidget::QgsComposerAttributeTableWidget( QgsComposerAtt
   connect( mContentFontToolButton, &QgsFontButton::changed, this, &QgsComposerAttributeTableWidget::contentFontChanged );
 }
 
-QgsComposerAttributeTableWidget::~QgsComposerAttributeTableWidget()
-{
-}
-
 void QgsComposerAttributeTableWidget::on_mRefreshPushButton_clicked()
 {
   if ( !mComposerTable )

src/app/composer/qgscomposerattributetablewidget.h

@@ -29,7 +29,6 @@ class QgsComposerAttributeTableWidget: public QgsComposerItemBaseWidget, private
     Q_OBJECT
   public:
     QgsComposerAttributeTableWidget( QgsComposerAttributeTableV2 *table, QgsComposerFrame *frame );
-    ~QgsComposerAttributeTableWidget();
 
   private:
     QgsComposerAttributeTableV2 *mComposerTable = nullptr;

src/app/composer/qgscomposerhtmlwidget.cpp

@@ -76,10 +76,6 @@ QgsComposerHtmlWidget::QgsComposerHtmlWidget()
 {
 }
 
-QgsComposerHtmlWidget::~QgsComposerHtmlWidget()
-{
-}
-
 void QgsComposerHtmlWidget::blockSignals( bool block )
 {
   mUrlLineEdit->blockSignals( block );

src/app/composer/qgscomposerhtmlwidget.h

@@ -28,7 +28,6 @@ class QgsComposerHtmlWidget: public QgsComposerItemBaseWidget, private Ui::QgsCo
     Q_OBJECT
   public:
     QgsComposerHtmlWidget( QgsComposerHtml *html, QgsComposerFrame *frame );
-    ~QgsComposerHtmlWidget();
 
   private slots:
     void on_mUrlLineEdit_editingFinished();

src/app/composer/qgscomposeritemwidget.cpp

@@ -40,10 +40,6 @@ QgsComposerConfigObject::QgsComposerConfigObject( QWidget *parent, QgsComposerOb
   connect( atlasComposition(), &QgsAtlasComposition::toggled, this, &QgsComposerConfigObject::updateDataDefinedButtons );
 }
 
-QgsComposerConfigObject::~QgsComposerConfigObject()
-{
-}
-
 void QgsComposerConfigObject::updateDataDefinedProperty()
 {
   //match data defined button to item's data defined property
@@ -183,11 +179,6 @@ QgsComposerItemWidget::QgsComposerItemWidget( QWidget *parent, QgsComposerItem *
     connect( mItem->composition(), &QgsComposition::variablesChanged, this, &QgsComposerItemWidget::updateVariables );
 }
 
-QgsComposerItemWidget::~QgsComposerItemWidget()
-{
-
-}
-
 void QgsComposerItemWidget::showBackgroundGroup( bool showGroup )
 {
   mBackgroundGroupBox->setVisible( showGroup );

src/app/composer/qgscomposeritemwidget.h

@@ -53,7 +53,6 @@ class QgsComposerConfigObject: public QObject
     Q_OBJECT
   public:
     QgsComposerConfigObject( QWidget *parent, QgsComposerObject *composerObject );
-    ~QgsComposerConfigObject();
 
     /** Registers a data defined button, setting up its initial value, connections and description.
      * \param button button to register
@@ -126,7 +125,6 @@ class QgsComposerItemWidget: public QWidget, private Ui::QgsComposerItemWidgetBa
     Q_OBJECT
   public:
     QgsComposerItemWidget( QWidget *parent, QgsComposerItem *item );
-    ~QgsComposerItemWidget();
 
     //! A combination of upper/middle/lower and left/middle/right
     QgsComposerItem::ItemPositionMode positionMode() const;

src/app/composer/qgscomposerlegendlayersdialog.cpp

@@ -29,14 +29,9 @@ QgsComposerLegendLayersDialog::QgsComposerLegendLayersDialog( QList<QgsMapLayer
   }
 }
 
-QgsComposerLegendLayersDialog::QgsComposerLegendLayersDialog(): QDialog( nullptr )
+QgsComposerLegendLayersDialog::QgsComposerLegendLayersDialog()
+  : QDialog( nullptr )
 {
-
-}
-
-QgsComposerLegendLayersDialog::~QgsComposerLegendLayersDialog()
-{
-
 }
 
 QgsMapLayer *QgsComposerLegendLayersDialog::selectedLayer()

src/app/composer/qgscomposerlegendlayersdialog.h

@@ -28,7 +28,7 @@ class QgsComposerLegendLayersDialog: public QDialog, private Ui::QgsComposerLege
 
   public:
     QgsComposerLegendLayersDialog( QList<QgsMapLayer *> layers, QWidget *parent = nullptr );
-    ~QgsComposerLegendLayersDialog();
+
     QgsMapLayer *selectedLayer();
 
   private:

src/app/composer/qgscomposerlegendwidget.cpp

@@ -124,11 +124,6 @@ QgsComposerLegendWidget::QgsComposerLegendWidget(): QgsComposerItemBaseWidget( n
   setupUi( this );
 }
 
-QgsComposerLegendWidget::~QgsComposerLegendWidget()
-{
-
-}
-
 void QgsComposerLegendWidget::setGuiElements()
 {
   if ( !mLegend )

src/app/composer/qgscomposerlegendwidget.h

@@ -35,7 +35,6 @@ class QgsComposerLegendWidget: public QgsComposerItemBaseWidget, private Ui::Qgs
 
   public:
     explicit QgsComposerLegendWidget( QgsComposerLegend *legend );
-    ~QgsComposerLegendWidget();
 
     //! Updates the legend layers and groups
     void updateLegend();

src/app/composer/qgscomposermapgridwidget.cpp

@@ -105,10 +105,6 @@ QgsComposerMapGridWidget::QgsComposerMapGridWidget( QgsComposerMapGrid *mapGrid,
   connect( mAnnotationFontButton, &QgsFontButton::changed, this, &QgsComposerMapGridWidget::annotationFontChanged );
 }
 
-QgsComposerMapGridWidget::~QgsComposerMapGridWidget()
-{
-}
-
 void QgsComposerMapGridWidget::populateDataDefinedButtons()
 {
   // none for now

src/app/composer/qgscomposermapgridwidget.h

@@ -31,7 +31,6 @@ class QgsComposerMapGridWidget: public QgsComposerItemBaseWidget, private Ui::Qg
 
   public:
     explicit QgsComposerMapGridWidget( QgsComposerMapGrid *mapGrid, QgsComposerMap *composerMap );
-    virtual ~QgsComposerMapGridWidget();
 
   public slots:
 

src/app/composer/qgscomposermapwidget.cpp

@@ -122,10 +122,6 @@ QgsComposerMapWidget::QgsComposerMapWidget( QgsComposerMap *composerMap )
   blockAllSignals( false );
 }
 
-QgsComposerMapWidget::~QgsComposerMapWidget()
-{
-}
-
 void QgsComposerMapWidget::populateDataDefinedButtons()
 {
   updateDataDefinedButton( mScaleDDBtn );

src/app/composer/qgscomposermapwidget.h

@@ -34,7 +34,6 @@ class QgsComposerMapWidget: public QgsComposerItemBaseWidget, private Ui::QgsCom
 
   public:
     explicit QgsComposerMapWidget( QgsComposerMap *composerMap );
-    virtual ~QgsComposerMapWidget();
 
   public slots:
     void on_mScaleLineEdit_editingFinished();

src/app/composer/qgscomposerpicturewidget.cpp

@@ -85,11 +85,6 @@ QgsComposerPictureWidget::QgsComposerPictureWidget( QgsComposerPicture *picture
   registerDataDefinedButton( mStrokeWidthDDBtn, QgsComposerObject::PictureSvgStrokeWidth );
 }
 
-QgsComposerPictureWidget::~QgsComposerPictureWidget()
-{
-
-}
-
 void QgsComposerPictureWidget::on_mPictureBrowseButton_clicked()
 {
   QgsSettings s;

src/app/composer/qgscomposerpicturewidget.h

@@ -32,7 +32,6 @@ class QgsComposerPictureWidget: public QgsComposerItemBaseWidget, private Ui::Qg
 
   public:
     explicit QgsComposerPictureWidget( QgsComposerPicture *picture );
-    ~QgsComposerPictureWidget();
 
     //! Add the icons of the standard directories to the preview
     void addStandardDirectoriesToPreview();

src/app/composer/qgscomposerpolygonwidget.cpp

@@ -45,10 +45,6 @@ QgsComposerPolygonWidget::QgsComposerPolygonWidget( QgsComposerPolygon *composer
   }
 }
 
-QgsComposerPolygonWidget::~QgsComposerPolygonWidget()
-{
-}
-
 void QgsComposerPolygonWidget::on_mPolygonStyleButton_clicked()
 {
   if ( !mComposerPolygon )

src/app/composer/qgscomposerpolygonwidget.h

@@ -31,7 +31,6 @@ class QgsComposerPolygonWidget: public QgsComposerItemBaseWidget, private Ui::Qg
     Q_OBJECT
   public:
     explicit QgsComposerPolygonWidget( QgsComposerPolygon *composerPolygon );
-    ~QgsComposerPolygonWidget();
 
   private:
     QgsComposerPolygon *mComposerPolygon = nullptr;

src/app/composer/qgscomposerpolylinewidget.cpp

@@ -42,10 +42,6 @@ QgsComposerPolylineWidget::QgsComposerPolylineWidget( QgsComposerPolyline *compo
     connect( mComposerPolyline, &QgsComposerObject::itemChanged, this, &QgsComposerPolylineWidget::setGuiElementValues );
 }
 
-QgsComposerPolylineWidget::~QgsComposerPolylineWidget()
-{
-}
-
 void QgsComposerPolylineWidget::on_mLineStyleButton_clicked()
 {
   if ( !mComposerPolyline )

src/app/composer/qgscomposerpolylinewidget.h

@@ -31,7 +31,6 @@ class QgsComposerPolylineWidget: public QgsComposerItemBaseWidget, private Ui::Q
     Q_OBJECT
   public:
     explicit QgsComposerPolylineWidget( QgsComposerPolyline *composerPolyline );
-    ~QgsComposerPolylineWidget();
 
   private:
     QgsComposerPolyline *mComposerPolyline = nullptr;

src/app/composer/qgscomposerscalebarwidget.cpp

@@ -104,11 +104,6 @@ QgsComposerScaleBarWidget::QgsComposerScaleBarWidget( QgsComposerScaleBar *scale
   connect( mFontButton, &QgsFontButton::changed, this, &QgsComposerScaleBarWidget::fontChanged );
 }
 
-QgsComposerScaleBarWidget::~QgsComposerScaleBarWidget()
-{
-
-}
-
 void QgsComposerScaleBarWidget::setGuiElements()
 {
   if ( !mComposerScaleBar )

src/app/composer/qgscomposerscalebarwidget.h

@@ -31,7 +31,6 @@ class QgsComposerScaleBarWidget: public QgsComposerItemBaseWidget, private Ui::Q
 
   public:
     explicit QgsComposerScaleBarWidget( QgsComposerScaleBar *scaleBar );
-    ~QgsComposerScaleBarWidget();
 
   public slots:
 

src/app/composer/qgscomposershapewidget.cpp

@@ -60,11 +60,6 @@ QgsComposerShapeWidget::QgsComposerShapeWidget( QgsComposerShape *composerShape
   mShapeStyleButton->setLayer( atlasCoverageLayer() );
 }
 
-QgsComposerShapeWidget::~QgsComposerShapeWidget()
-{
-
-}
-
 void QgsComposerShapeWidget::blockAllSignals( bool block )
 {
   mShapeComboBox->blockSignals( block );

src/app/composer/qgscomposershapewidget.h

@@ -29,7 +29,6 @@ class QgsComposerShapeWidget: public QgsComposerItemBaseWidget, private Ui::QgsC
     Q_OBJECT
   public:
     explicit QgsComposerShapeWidget( QgsComposerShape *composerShape );
-    ~QgsComposerShapeWidget();
 
   private:
     QgsComposerShape *mComposerShape = nullptr;