-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FEATURE] Parameterized svg support for composer svg images
This makes it possible to change SVG fill/outline color and outline width when using parameterised SVG files such as those included with QGIS (fix #10542) (cherry-picked from ed3cb12)
- Loading branch information
1 parent
9542653
commit 0cdfca7
Showing
9 changed files
with
519 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
0cdfca7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this an oversight to add new features in the LTR branch? @jef-n @mhugent
0cdfca7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson
0cdfca7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, released. Are there any restrictions on features which can be merged in the LTR? Is there a feature freeze deadline for 2.14.2, @jef-n?
0cdfca7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new features should be merged.
0cdfca7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some discussion in #2876 on github and on irc. But this is the only way to solve #10542, and given the severity of that bug it was decided it's better to allow a feature then suffer that bug for all of 2.14.