Skip to content

Commit

Permalink
Fix error when trying to run processing algs
Browse files Browse the repository at this point in the history 
Caused by trying to deepcopy a c++ object. This is a temporary
fix - when the next part of the processing/c++ work lands algorithm
copies will no longer be required
  • Loading branch information
@nyalldawson
nyalldawson committed Apr 6, 2017
1 parent 85b38e3 commit 0e72fe0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/plugins/processing/core/GeoAlgorithm.py
100644 → 100755
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def getCopy(self):
"""Returns a new instance of this algorithm, ready to be used
for being executed.
"""
newone = copy.copy(self)
newone = self
newone.parameters = copy.deepcopy(self.parameters)
newone.outputs = copy.deepcopy(self.outputs)
return newone
Expand Down

4 comments on commit 0e72fe0

@PedroVenancio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nyall,

I think one of your commits 51517fd or 377b181 introduced an error on Processing. I've compiled master on Linux early this night and SAGA 3.2.1 appears only with one algorithm (Split RGB bands), and GRASS7.2 does not work (Problem executing algorithm - local variable 'filename' referenced before assignment See log for more details).

Then I've compiled QGIS 3 code just after Victor commit 439b9de, and SAGA and GRASS7.2 works ok.

This commit fixes these problems?

Thank you very much!

Best regards,
Pedro

@nyalldawson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PedroVenancio

There's a few known issues in processing at the moment. Unfortunately my refactoring will shake things up a bit short term, and some breakages like this is expected until the rest of the refactoring is merged.

@gioman
Copy link
Contributor

@gioman gioman commented on 0e72fe0 Apr 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson @PedroVenancio

There's a few known issues in processing at the moment. Unfortunately my refactoring will shake things up a bit short term, and some breakages like this is expected until the rest of the refactoring is merged.

is there already a ticket as a reminder?

@jef-n
Copy link
Member

@jef-n jef-n commented on 0e72fe0 Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #16421

Please sign in to comment.