Skip to content
Permalink
Browse files
Fix error when trying to run processing algs
Caused by trying to deepcopy a c++ object. This is a temporary
fix - when the next part of the processing/c++ work lands algorithm
copies will no longer be required
  • Loading branch information
nyalldawson committed Apr 6, 2017
1 parent 85b38e3 commit 0e72fe0591f0a346e6e6b9597d302df5918ebcd6
Showing with 1 addition and 1 deletion.
  1. +1 −1 python/plugins/processing/core/GeoAlgorithm.py
@@ -82,7 +82,7 @@ def getCopy(self):
"""Returns a new instance of this algorithm, ready to be used
for being executed.
"""
newone = copy.copy(self)
newone = self
newone.parameters = copy.deepcopy(self.parameters)
newone.outputs = copy.deepcopy(self.outputs)
return newone

4 comments on commit 0e72fe0

@PedroVenancio

This comment has been minimized.

Copy link
Contributor

@PedroVenancio PedroVenancio replied Apr 7, 2017

Hi Nyall,

I think one of your commits 51517fd or 377b181 introduced an error on Processing. I've compiled master on Linux early this night and SAGA 3.2.1 appears only with one algorithm (Split RGB bands), and GRASS7.2 does not work (Problem executing algorithm - local variable 'filename' referenced before assignment See log for more details).

Then I've compiled QGIS 3 code just after Victor commit 439b9de, and SAGA and GRASS7.2 works ok.

This commit fixes these problems?

Thank you very much!

Best regards,
Pedro

@nyalldawson

This comment has been minimized.

Copy link
Collaborator Author

@nyalldawson nyalldawson replied Apr 7, 2017

@PedroVenancio

There's a few known issues in processing at the moment. Unfortunately my refactoring will shake things up a bit short term, and some breakages like this is expected until the rest of the refactoring is merged.

@gioman

This comment has been minimized.

Copy link
Contributor

@gioman gioman replied Apr 7, 2017

@nyalldawson @PedroVenancio

There's a few known issues in processing at the moment. Unfortunately my refactoring will shake things up a bit short term, and some breakages like this is expected until the rest of the refactoring is merged.

is there already a ticket as a reminder?

@jef-n

This comment has been minimized.

Copy link
Member

@jef-n jef-n replied Aug 9, 2017

See #16421

Please sign in to comment.