Fix infinite loop in relation reference widget

m-kuhn · m-kuhn · commit 104ff2a975f5 · 2015-05-30T18:15:12.000+02:00
diff --git a/src/gui/editorwidgets/qgsrelationreferencewidgetwrapper.cpp b/src/gui/editorwidgets/qgsrelationreferencewidgetwrapper.cpp
@@ -99,12 +99,12 @@ QVariant QgsRelationReferenceWidgetWrapper::value()
   }
 }
 
-void QgsRelationReferenceWidgetWrapper::setValue( const QVariant& value )
+void QgsRelationReferenceWidgetWrapper::setValue( const QVariant& val )
 {
-  if ( !mWidget )
+  if ( !mWidget || val == value() )
     return;
 
-  mWidget->setForeignKey( value );
+  mWidget->setForeignKey( val );
 }
 
 void QgsRelationReferenceWidgetWrapper::setEnabled( bool enabled )

Original file line number	Diff line number	Diff line change
`@@ -99,12 +99,12 @@ QVariant QgsRelationReferenceWidgetWrapper::value()`
`99`	`99`	`}`
`100`	`100`	`}`
`101`	`101`
`102`		`-void QgsRelationReferenceWidgetWrapper::setValue( const QVariant& value )`
	`102`	`+void QgsRelationReferenceWidgetWrapper::setValue( const QVariant& val )`
`103`	`103`	`{`
`104`		`- if ( !mWidget )`
	`104`	`+ if ( !mWidget \|\| val == value() )`
`105`	`105`	`return;`
`106`	`106`
`107`		`- mWidget->setForeignKey( value );`
	`107`	`+ mWidget->setForeignKey( val );`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`void QgsRelationReferenceWidgetWrapper::setEnabled( bool enabled )`