Merge pull request #52736 from troopa81/fix_transaction_create_oracle

[Oracle] Fix transaction creation
qgis · Apr 18, 2023 · 121f46a · 121f46a
2 parents bc114fb + 49e920b
commit 121f46a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/providers/oracle/qgsoracleconn.cpp b/src/providers/oracle/qgsoracleconn.cpp
@@ -528,7 +528,7 @@ bool QgsOracleConn::execLogged( const QString &query, bool logError, QString *er
 
   QSqlQuery qry( mDatabase );
 
-  const bool res { !exec( qry, query, QVariantList() ) };
+  const bool res { exec( qry, query, QVariantList() ) };
 
   logWrapper.setQuery( qry.lastQuery() );
 

diff --git a/tests/src/python/test_provider_oracle.py b/tests/src/python/test_provider_oracle.py
@@ -733,6 +733,16 @@ def testNestedInsert(self):
         f['pk'] = NULL
         self.vl.addFeature(f)  # Should not deadlock during an active iteration
         f = next(it)
+        self.vl.rollBack()
+
+    def testTransactionEditing(self):
+        tg = QgsTransactionGroup()
+        tg.addLayer(self.vl)
+        self.vl.startEditing()
+        feat = QgsFeature(self.vl.fields())
+        feat.setAttribute("pk", 6)
+        self.assertTrue(self.vl.addFeature(feat))
+        self.vl.rollBack()
 
     def testTimeout(self):
         """